Adds conversion rule for WebAXRoleDetails

Adds conversion rule for WebAXRoleDetails

This CL depends on blink side CL https://codereview.chromium.org/590183003/

BUG=282016
Committed: https://crrev.com/cfe6b43f2efb2a2212cf0abae532854778f5b68d
Cr-Commit-Position: refs/heads/master@{#297488}

[shreeramk, 2014-09-23 13:45:06]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org, kenjibaheux@chromium.org

[shreeramk, 2014-09-23 13:45:07]

Please review!

Thanks.

[shreeramk, 2014-09-23 13:45:54]

shreeram.k@samsung.com changed reviewers:
+ dtseng@chromium.org

[shreeramk, 2014-09-24 08:13:03]

On 2014/09/23 13:45:07, shreeram.k wrote:
> Please review!
> 
> Thanks.

Sorry, first blink side changes has to be merged. Then only the try bots will
pass.

[dmazzoni, 2014-09-24 19:32:24]

https://codereview.chromium.org/591363003/diff/20001/content/test/data/access...
File content/test/data/accessibility/details-expected-win.txt (right):

https://codereview.chromium.org/591363003/diff/20001/content/test/data/access...
content/test/data/accessibility/details-expected-win.txt:4:
ROLE_SYSTEM_STATICTEXT name='details tag'
This is the <summary> element - I believe it should have a BUTTON role.

https://codereview.chromium.org/591363003/diff/20001/content/test/data/access...
File content/test/data/accessibility/details.html (right):

https://codereview.chromium.org/591363003/diff/20001/content/test/data/access...
content/test/data/accessibility/details.html:5: <details>
It'd be nice to have two details elements in the page, one closed (<details>)
and one open (<details open>).

https://codereview.chromium.org/591363003/diff/20001/content/test/data/access...
content/test/data/accessibility/details.html:6: <summary>details tag</summary>
nit: indent all of the lines inside of <details> to make it easier to read.

https://codereview.chromium.org/591363003/diff/20001/content/test/data/access...
content/test/data/accessibility/details.html:7: <p>The <details> tag specifies
additional details that the user can view or hide on demand.</p>
You should escape the < > as &gt; &lt; otherwise you're actually adding a
<details> tag inside the paragraph.

[shreeramk, 2014-09-25 12:07:14]

Updated based on comments.

On 2014/09/24 19:32:24, dmazzoni wrote:
>
https://codereview.chromium.org/591363003/diff/20001/content/test/data/access...
> content/test/data/accessibility/details-expected-win.txt:4:
> ROLE_SYSTEM_STATICTEXT name='details tag'
> This is the <summary> element - I believe it should have a BUTTON role.

Chromium side changes required for summary tag - I have updated in this CL's
Patch set 3.

But BLINK side changes are also required. Once blink side changes will be merged
then this can be taken forward. Here is the blink side CL
https://codereview.chromium.org/594843004/


>
https://codereview.chromium.org/591363003/diff/20001/content/test/data/access...
> content/test/data/accessibility/details.html:5: <details>
> It'd be nice to have two details elements in the page, one closed (<details>)
> and one open (<details open>).

Updated details.html file to have <details open>

>
https://codereview.chromium.org/591363003/diff/20001/content/test/data/access...
> content/test/data/accessibility/details.html:6: <summary>details tag</summary>
> nit: indent all of the lines inside of <details> to make it easier to read.

Fixed the nit.

[shreeramk, 2014-09-26 15:26:58]

PTAL!

Blink side changes has been merged.

[dmazzoni, 2014-09-26 15:34:19]

https://codereview.chromium.org/591363003/diff/60001/content/test/data/access...
File content/test/data/accessibility/details-expected-mac.txt (right):

https://codereview.chromium.org/591363003/diff/60001/content/test/data/access...
content/test/data/accessibility/details-expected-mac.txt:3: AXGroup
AXTitle='details tag'
I believe this should be AXDisclosureTriangle, according to
http://www.w3.org/TR/html-aapi/#summary-and-details-elements

Note that from http://www.w3.org/TR/html-aapi if you click on "Latest editor's
draft" the table of elements is more complete, it specifies exactly what you
should do for summary and details on Mac.

https://codereview.chromium.org/591363003/diff/60001/content/test/data/access...
File content/test/data/accessibility/details-expected-win.txt (right):

https://codereview.chromium.org/591363003/diff/60001/content/test/data/access...
content/test/data/accessibility/details-expected-win.txt:3:
ROLE_SYSTEM_PUSHBUTTON name='details tag' FOCUSABLE
Windows looks good!

[shreeramk, 2014-09-26 17:44:10]

On 2014/09/26 15:34:19, dmazzoni wrote:
>
https://codereview.chromium.org/591363003/diff/60001/content/test/data/access...
> File content/test/data/accessibility/details-expected-mac.txt (right):
> 
>
https://codereview.chromium.org/591363003/diff/60001/content/test/data/access...
> content/test/data/accessibility/details-expected-mac.txt:3: AXGroup
> AXTitle='details tag'
> I believe this should be AXDisclosureTriangle, according to
> http://www.w3.org/TR/html-aapi/#summary-and-details-elements
> 
> Note that from http://www.w3.org/TR/html-aapi if you click on "Latest editor's
> draft" the table of elements is more complete, it specifies exactly what you
> should do for summary and details on Mac.

Yeah correct. I totally forget to check for Mac.

[shreeramk, 2014-09-30 11:21:51]

PTAL!

Correct AXRole and AXRoleDescription for summary tag was not dumped because
@MAC-ALLOW:AXRole* was not used in details.html. Now after adding its working
fine.

One more thing, while uploading the patch I got following error. 

This branch is associated with issue 591363003. Adding patch to that issue.
Upload server: https://codereview.chromium.org (change with -s/--server)
Loaded authentication cookies from /home/shreeram.k/.codereview_upload_cookies
Title describing this patch set: 
Issue updated. URL: https://codereview.chromium.org/591363003


Traceback (most recent call last):
  File "/home/shreeram.k/tizwork/codeSpace/openSource/depot_tools/git_cl.py",
line 2883, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/shreeram.k/tizwork/codeSpace/openSource/depot_tools/git_cl.py",
line 2869, in main
    return dispatcher.execute(OptionParser(), argv)
  File
"/home/shreeram.k/tizwork/codeSpace/openSource/depot_tools/subcommand.py", line
245, in execute
    return command(parser, args[1:])
  File "/home/shreeram.k/tizwork/codeSpace/openSource/depot_tools/git_cl.py",
line 1849, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/home/shreeram.k/tizwork/codeSpace/openSource/depot_tools/git_cl.py",
line 1714, in RietveldUpload
    issue, patchset = upload.RealMain(upload_args)
  File
"/home/shreeram.k/tizwork/codeSpace/openSource/depot_tools/third_party/upload.py",
line 2686, in RealMain
    vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
  File
"/home/shreeram.k/tizwork/codeSpace/openSource/depot_tools/third_party/upload.py",
line 1218, in UploadBaseFiles
    print t.get(timeout=60)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 524, in get
    raise TimeoutError
multiprocessing.TimeoutError


From which its clear that, it has been updated on the server. But if you notice
there is no delta between patchset 5 and other patchsets(1,2,3,4).

Is this fine???

[dmazzoni, 2014-09-30 15:07:45]

On 2014/09/30 11:21:51, shreeram.k wrote:
> From which its clear that, it has been updated on the server. But if you
notice
> there is no delta between patchset 5 and other patchsets(1,2,3,4).
> 
> Is this fine???

Not sure what happened, but I think it's fine.

[dmazzoni, 2014-09-30 15:08:56]

lgtm

[shreeramk, 2014-09-30 16:14:56]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-09-30 16:15:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591363003/80001

[commit-bot: I haz the power, 2014-09-30 20:05:05]

Committed patchset #5 (id:80001) as 2c5411047765f334299604ac4d9363fb70e9405c

[commit-bot: I haz the power, 2014-09-30 20:05:38]

Patchset 5 (id:??) landed as
https://crrev.com/cfe6b43f2efb2a2212cf0abae532854778f5b68d
Cr-Commit-Position: refs/heads/master@{#297488}