Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 590183003: Adds accessibility role for details element (Closed)

Created:
6 years, 3 months ago by shreeramk
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, aboxhall, abarth-chromium, dglazkov+blink, dmazzoni, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adds accessibility role for details element BUG=282016 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
shreeramk
Please review! Thanks.
6 years, 3 months ago (2014-09-23 13:42:37 UTC) #2
dmazzoni
lgtm
6 years, 3 months ago (2014-09-24 19:26:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590183003/1
6 years, 3 months ago (2014-09-24 19:27:10 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 20:07:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182631

Powered by Google App Engine
This is Rietveld 408576698