Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 59133008: ozone: Support building without cairo (Closed)

Created:
7 years, 1 month ago by spang
Modified:
7 years, 1 month ago
Reviewers:
reed, Nico, sky, reed1
CC:
chromium-reviews, ozone-dev_chromium.org
Visibility:
Public.

Description

ozone: Support building without cairo This adds a use_cairo gyp variable that removes cairo from the build. To build skia without cairo, we need the code in bitmap_platform_device_android.cc. To make all platforms build the correct files, rename bitmap_platform_device_linux to bitmap_platform_device_cairo and rename bitmap_platform_device_android to bitmap_platform_device_skia. We'll use bitmap_platform_device_skia for Android and for embedded content shell. BUG=318315, 318413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236037

Patch Set 1 #

Patch Set 2 : fix image_unittest #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : rebase & fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -524 lines) Patch
M build/common.gypi View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
M skia/ext/bitmap_platform_device.h View 1 chunk +4 lines, -4 lines 0 comments Download
D skia/ext/bitmap_platform_device_android.h View 1 chunk +0 lines, -60 lines 0 comments Download
D skia/ext/bitmap_platform_device_android.cc View 1 chunk +0 lines, -99 lines 0 comments Download
A + skia/ext/bitmap_platform_device_cairo.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +1 line, -1 line 0 comments Download
D skia/ext/bitmap_platform_device_linux.h View 1 chunk +0 lines, -114 lines 0 comments Download
D skia/ext/bitmap_platform_device_linux.cc View 1 chunk +0 lines, -219 lines 0 comments Download
A + skia/ext/bitmap_platform_device_skia.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + skia/ext/bitmap_platform_device_skia.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/platform_device.h View 2 chunks +5 lines, -7 lines 0 comments Download
M skia/skia_chrome.gypi View 2 chunks +9 lines, -4 lines 0 comments Download
M skia/skia_common.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M skia/skia_library.gypi View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M ui/gfx/blit.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/gfx/image/image_unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/native_widget_types.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
spang
7 years, 1 month ago (2013-11-13 21:43:33 UTC) #1
spang
7 years, 1 month ago (2013-11-13 23:18:39 UTC) #2
spang
7 years, 1 month ago (2013-11-14 15:51:15 UTC) #3
sky
ui LGTM https://codereview.chromium.org/59133008/diff/90001/ui/gfx/image/image_unittest.cc File ui/gfx/image/image_unittest.cc (right): https://codereview.chromium.org/59133008/diff/90001/ui/gfx/image/image_unittest.cc#newcode26 ui/gfx/image/image_unittest.cc:26: #if defined(TOOLKIT_VIEWS) || defined(OS_ANDROID) || (defined(OS_LINUX) && ...
7 years, 1 month ago (2013-11-14 17:22:59 UTC) #4
spang
https://codereview.chromium.org/59133008/diff/90001/ui/gfx/image/image_unittest.cc File ui/gfx/image/image_unittest.cc (right): https://codereview.chromium.org/59133008/diff/90001/ui/gfx/image/image_unittest.cc#newcode26 ui/gfx/image/image_unittest.cc:26: #if defined(TOOLKIT_VIEWS) || defined(OS_ANDROID) || (defined(OS_LINUX) && !defined(USE_CAIRO)) On ...
7 years, 1 month ago (2013-11-14 20:08:38 UTC) #5
spang
7 years, 1 month ago (2013-11-14 20:11:14 UTC) #6
reed1
lgtm
7 years, 1 month ago (2013-11-19 17:30:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/59133008/150001
7 years, 1 month ago (2013-11-19 17:50:46 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=156517
7 years, 1 month ago (2013-11-19 18:19:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/59133008/150001
7 years, 1 month ago (2013-11-19 19:05:42 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 20:17:20 UTC) #11
Message was sent while issue was closed. 
Change committed as 236037

Powered by Google App Engine
This is Rietveld 408576698