Source/web/WebRemoteFrameImpl.h - Issue 591053002: Support print preset options for pdf document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.h

Issue 591053002: Support print preset options for pdf document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review feedback (comment, initialization) Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebRemoteFrameImpl.h

diff --git a/Source/web/WebRemoteFrameImpl.h b/Source/web/WebRemoteFrameImpl.h

index 0f2eb62d53442295229cac6ae0f43862fc7333f4..5f7f96fb3c2df67052ee73d7f94767349a189e71 100644

--- a/Source/web/WebRemoteFrameImpl.h

+++ b/Source/web/WebRemoteFrameImpl.h

@@ -130,7 +130,7 @@ public:

virtual float getPrintPageShrink(int page) override;

virtual void printEnd() override;

virtual bool isPrintScalingDisabledForPlugin(const WebNode&) override;

- virtual int getPrintCopiesForPlugin(const WebNode&) override;

+ virtual bool getPrintPresetOptionsForPlugin(const WebNode&, WebPrintPresetOptions*) override;

virtual bool hasCustomPageSizeStyle(int pageIndex) override;

virtual bool isPageBoxVisible(int pageIndex) override;

virtual void pageSizeAndMarginsInPixels(