Source/web/WebPluginContainerImpl.cpp - Issue 591053002: Support print preset options for pdf document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPluginContainerImpl.cpp

Issue 591053002: Support print preset options for pdf document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review feedback (comment, initialization) Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebPluginContainerImpl.cpp

diff --git a/Source/web/WebPluginContainerImpl.cpp b/Source/web/WebPluginContainerImpl.cpp

index d93a9df6457773ad727018c1bf59805a0f89fc63..70c91a2389ef2a5c86bd3897dbc51f63a3d59e56 100644

--- a/Source/web/WebPluginContainerImpl.cpp

+++ b/Source/web/WebPluginContainerImpl.cpp

@@ -86,6 +86,7 @@

#include "public/web/WebInputEvent.h"

#include "public/web/WebPlugin.h"

#include "public/web/WebPrintParams.h"

+#include "public/web/WebPrintPresetOptions.h"

#include "public/web/WebViewClient.h"

#include "web/ChromeClientImpl.h"

#include "web/ScrollbarGroup.h"

@@ -323,9 +324,9 @@ bool WebPluginContainerImpl::isPrintScalingDisabled() const

return m_webPlugin->isPrintScalingDisabled();

}

-int WebPluginContainerImpl::getCopiesToPrint() const

+bool WebPluginContainerImpl::getPrintPresetOptionsFromDocument(WebPrintPresetOptions* presetOptions) const

{

- return m_webPlugin->getCopiesToPrint();

+ return m_webPlugin->getPrintPresetOptionsFromDocument(presetOptions);

}

int WebPluginContainerImpl::printBegin(const WebPrintParams& printParams) const