Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2700)

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 591053002: Support print preset options for pdf document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review feedback (comment, initialization) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebRemoteFrameImpl.cpp
diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp
index 3d23b85bd385f1d22e704559378b6b9227c858a2..ded07ee3e6dbd8f1462081b642e9288c8b9743be 100644
--- a/Source/web/WebRemoteFrameImpl.cpp
+++ b/Source/web/WebRemoteFrameImpl.cpp
@@ -661,10 +661,10 @@ bool WebRemoteFrameImpl::isPrintScalingDisabledForPlugin(const WebNode&)
return false;
}
-int WebRemoteFrameImpl::getPrintCopiesForPlugin(const WebNode&)
+bool WebRemoteFrameImpl::getPrintPresetOptionsForPlugin(const WebNode&, WebPrintPresetOptions*)
dcheng 2014/10/09 08:53:42 Since we're changing this signature anyway, how ha
Nikhil 2014/10/20 10:04:23 Based on your suggestion, I've moved the new metho
{
ASSERT_NOT_REACHED();
- return 1;
+ return false;
}
bool WebRemoteFrameImpl::hasCustomPageSizeStyle(int pageIndex)
« no previous file with comments | « Source/web/WebRemoteFrameImpl.h ('k') | public/web/WebFrame.h » ('j') | public/web/WebFrame.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698