Add support for icons.{src,type,density} in Manifest.

Add support for icons.{src,type,density} in Manifest.

This is not yet supporting icons.sizes. It will be
implemented in a separate CL because the algorithm might be
more complex and could require some code sharing with Blink.

BUG=366145
Committed: https://crrev.com/c00b78f53f2bc38d19c0dd671a6558160d98f808
Cr-Commit-Position: refs/heads/master@{#296382}

[mlamouri (slow - plz ping), 2014-09-22 11:08:26]

mlamouri@chromium.org changed reviewers:
+ avi@chromium.org, palmer@chromium.org

[mlamouri (slow - plz ping), 2014-09-22 11:08:27]

avi@, could you review the changen in content/

palmer@, could you review the IPC changes

Thanks :)

[Avi (use Gerrit), 2014-09-22 14:55:24]

lgtm

[palmer, 2014-09-22 20:35:43]

https://codereview.chromium.org/590563002/diff/60001/content/public/common/ma...
File content/public/common/manifest.cc (right):

https://codereview.chromium.org/590563002/diff/60001/content/public/common/ma...
content/public/common/manifest.cc:9: const double
Manifest::Icon::kDefaultDensity = 1;
IMO, this makes more sense in the header file.

https://codereview.chromium.org/590563002/diff/60001/content/public/common/ma...
File content/public/common/manifest.h (right):

https://codereview.chromium.org/590563002/diff/60001/content/public/common/ma...
content/public/common/manifest.h:43: base::NullableString16 type;
Ultimately, I'd expect the interface to "harden", and for this to become an
enum. How many possible MIME types do we really expect? Can we harden the
interface now, or soon?

Why not std::string?

https://codereview.chromium.org/590563002/diff/60001/content/renderer/manifes...
File content/renderer/manifest/manifest_parser.cc (right):

https://codereview.chromium.org/590563002/diff/60001/content/renderer/manifes...
content/renderer/manifest/manifest_parser.cc:169: const GURL& manifest_url) {
Nit: indentation

[mlamouri (slow - plz ping), 2014-09-22 21:09:32]

PTAL

https://codereview.chromium.org/590563002/diff/60001/content/public/common/ma...
File content/public/common/manifest.cc (right):

https://codereview.chromium.org/590563002/diff/60001/content/public/common/ma...
content/public/common/manifest.cc:9: const double
Manifest::Icon::kDefaultDensity = 1;
On 2014/09/22 20:35:43, Chromium Palmer wrote:
> IMO, this makes more sense in the header file.

I can't define it in the header. I get a static-float-init warning and requires
constexpr to fix that which is C++11.

https://codereview.chromium.org/590563002/diff/60001/content/public/common/ma...
File content/public/common/manifest.h (right):

https://codereview.chromium.org/590563002/diff/60001/content/public/common/ma...
content/public/common/manifest.h:43: base::NullableString16 type;
On 2014/09/22 20:35:43, Chromium Palmer wrote:
> Ultimately, I'd expect the interface to "harden", and for this to become an
> enum. How many possible MIME types do we really expect? Can we harden the
> interface now, or soon?
> 
> Why not std::string?

It's NullableString16 because the type might not be specified. It is an optional
information. This is the same reason why the interface isn't hardened: the final
consumer of that information might want to behave differently with regards to
missing or bogus values.

https://codereview.chromium.org/590563002/diff/60001/content/renderer/manifes...
File content/renderer/manifest/manifest_parser.cc (right):

https://codereview.chromium.org/590563002/diff/60001/content/renderer/manifes...
content/renderer/manifest/manifest_parser.cc:169: const GURL& manifest_url) {
On 2014/09/22 20:35:43, Chromium Palmer wrote:
> Nit: indentation

Done.

[palmer, 2014-09-23 21:20:14]

lgtm

[mlamouri (slow - plz ping), 2014-09-23 21:20:47]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:24:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/590563002/80001

[commit-bot: I haz the power, 2014-09-23 23:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 23:27:50]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[mlamouri (slow - plz ping), 2014-09-24 09:45:34]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-09-24 09:46:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/590563002/100001

[commit-bot: I haz the power, 2014-09-24 10:37:13]

Committed patchset #6 (id:100001) as 6fc7bab0c71576b1f9b0c759a6f791373ed82683

[commit-bot: I haz the power, 2014-09-24 10:37:43]

Patchset 6 (id:??) landed as
https://crrev.com/c00b78f53f2bc38d19c0dd671a6558160d98f808
Cr-Commit-Position: refs/heads/master@{#296382}