Add support for icons.{src,type,density} in Manifest.

content/public/common/manifest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/manifest.h"
 
 namespace content {
 
+const double Manifest::Icon::kDefaultDensity = 1;

[palmer, 2014/09/22 20:35:43]

IMO, this makes more sense in the header file.

[mlamouri (slow - plz ping), 2014/09/22 21:09:31]

I can't define it in the header. I get a static-float-init warning and requires
constexpr to fix that which is C++11.

 const size_t Manifest::kMaxIPCStringLength = 4 * 1024;
 
+Manifest::Icon::Icon()
+    : density(kDefaultDensity) {
+}
+
+Manifest::Icon::~Icon() {
+}
+
 Manifest::Manifest()
     : display(DISPLAY_MODE_UNSPECIFIED),
       orientation(blink::WebScreenOrientationLockDefault) {
 }
 
 Manifest::~Manifest() {
 }
 
 bool Manifest::IsEmpty() const {
   return name.is_null() &&
          short_name.is_null() &&
          start_url.is_empty() &&
          display == DISPLAY_MODE_UNSPECIFIED &&
-         orientation == blink::WebScreenOrientationLockDefault;
+         orientation == blink::WebScreenOrientationLockDefault &&
+         icons.empty();
 }
 
 } // namespace content