Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: content/public/common/manifest.cc

Issue 590563002: Add support for icons.{src,type,density} in Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: EXPORT Manifest::Icon Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/manifest.h ('k') | content/renderer/manifest/manifest_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/manifest.cc
diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc
index 9aeedd419193f20e40313c5e797ac44d83c181da..71b2cd2b128daf17309e632481fb9c88d9764c03 100644
--- a/content/public/common/manifest.cc
+++ b/content/public/common/manifest.cc
@@ -6,8 +6,16 @@
namespace content {
+const double Manifest::Icon::kDefaultDensity = 1;
const size_t Manifest::kMaxIPCStringLength = 4 * 1024;
+Manifest::Icon::Icon()
+ : density(kDefaultDensity) {
+}
+
+Manifest::Icon::~Icon() {
+}
+
Manifest::Manifest()
: display(DISPLAY_MODE_UNSPECIFIED),
orientation(blink::WebScreenOrientationLockDefault) {
@@ -21,7 +29,8 @@ bool Manifest::IsEmpty() const {
short_name.is_null() &&
start_url.is_empty() &&
display == DISPLAY_MODE_UNSPECIFIED &&
- orientation == blink::WebScreenOrientationLockDefault;
+ orientation == blink::WebScreenOrientationLockDefault &&
+ icons.empty();
}
} // namespace content
« no previous file with comments | « content/public/common/manifest.h ('k') | content/renderer/manifest/manifest_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698