Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 590183003: Adds accessibility role for details element (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXRenderObject.cpp
diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp
index 05c40804f5ff5fb854cd1445ab2f7325e8b6ff48..035d4e1f155a3568dea904a4bcb75cb66b2e5f3d 100644
--- a/Source/core/accessibility/AXRenderObject.cpp
+++ b/Source/core/accessibility/AXRenderObject.cpp
@@ -278,6 +278,8 @@ AccessibilityRole AXRenderObject::determineAccessibilityRole()
return ListMarkerRole;
if (isHTMLButtonElement(node))
return buttonRoleType();
+ if (isHTMLDetailsElement(node))
+ return DetailsRole;
if (isHTMLLegendElement(node))
return LegendRole;
if (m_renderer->isText())
@@ -683,6 +685,9 @@ bool AXRenderObject::computeAccessibilityIsIgnored() const
if (roleValue() == FigureRole)
return false;
+ if (roleValue() == DetailsRole)
+ return false;
+
// if this element has aria attributes on it, it should not be ignored.
if (supportsARIAAttributes())
return false;
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698