Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: tools/gn/target.cc

Issue 589753005: gn: Fix build issues blocking gfx from being built (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index d512894302eb2691c0bf9f58f6a1e785a4f63586..9368749856f2bc7ed154e06244a6bc1181b8244c 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -322,7 +322,7 @@ void Target::FillOutputFiles() {
if (!tool->depend_output().empty()) {
dependency_output_file_ =
SubstitutionWriter::ApplyPatternToLinkerAsOutputFile(
- this, tool, tool->link_output());
+ this, tool, tool->depend_output());
ckocagil 2014/09/21 02:05:05 I assume this was a copy/paste error.
brettw 2014/09/21 02:55:01 This should be fixed if you merge.
ckocagil 2014/09/21 11:47:27 I don't see a change on ToT: https://chromium.goog
brettw 2014/09/22 04:45:56 Oh whoops, haven't checked it in yet. See https://
ckocagil 2014/09/22 16:39:33 Okay, I removed the change here.
}
}
break;
« tools/gn/ninja_binary_target_writer.cc ('K') | « tools/gn/ninja_binary_target_writer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698