gn: Fix build issues blocking gfx from being built

tools/gn/ninja_binary_target_writer.cc

Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index 1480f69212430678f32f12d115fe18493537187e..62dd07e46ebff266f6405547c3ea494d2870b2e6 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -236,8 +236,9 @@ void NinjaBinaryTargetWriter::WriteLinkerStuff(
         cur->link_output_file().value()) {
       // This is a shared library with separate link and deps files. Save for
       // later.
+      implicit_deps.push_back(cur->link_output_file());

[ckocagil, 2014/09/21 02:05:05]

We should implicitly depend on both the dll and the lib.

       implicit_deps.push_back(cur->dependency_output_file());
-      solibs.push_back(cur->link_output_file());
+      solibs.push_back(cur->dependency_output_file());

[ckocagil, 2014/09/21 02:05:05]

We should output the .lib here, so it can be linked.

[brettw, 2014/09/21 02:55:00]

I *think* both of these lines were correct before. Did this change a test?

On Linux, it should look like:
  foo.exe: ... | mylib.so.TOC
and this shouldn't be hit on Windows (since the link & depend output files
should be the same).

[ckocagil, 2014/09/21 11:47:27]

Done.

     } else {
       // Normal case, just link to this target.
       out_ << " ";