gn: Fix build issues blocking gfx from being built

tools/gn/target.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/target.h"
 
 #include "base/bind.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "tools/gn/config_values_extractors.h"
@@ skipping 304 matching lines @@
       } else {
         // Use the tool-specified ones.
         if (!tool->link_output().empty()) {
           link_output_file_ =
               SubstitutionWriter::ApplyPatternToLinkerAsOutputFile(
                   this, tool, tool->link_output());
         }
         if (!tool->depend_output().empty()) {
           dependency_output_file_ =
               SubstitutionWriter::ApplyPatternToLinkerAsOutputFile(
-                  this, tool, tool->link_output());
+                  this, tool, tool->depend_output());

[ckocagil, 2014/09/21 02:05:05]

I assume this was a copy/paste error.

[brettw, 2014/09/21 02:55:01]

This should be fixed if you merge.

[ckocagil, 2014/09/21 11:47:27]

I don't see a change on ToT:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/target.cc

[brettw, 2014/09/22 04:45:56]

Oh whoops, haven't checked it in yet. See
https://codereview.chromium.org/583363003/ Since mine has a unit test, I'd
prefer it.

[ckocagil, 2014/09/22 16:39:33]

Okay, I removed the change here.

         }
       }
       break;
     case UNKNOWN:
     default:
       NOTREACHED();
   }
 }
 
 bool Target::CheckVisibility(Err* err) const {
@@ skipping 37 matching lines @@
 
   // Verify no inherited libraries are static libraries.
   for (size_t i = 0; i < inherited_libraries().size(); ++i) {
     if (inherited_libraries()[i]->output_type() == Target::STATIC_LIBRARY) {
       *err = MakeStaticLibDepsError(this, inherited_libraries()[i]);
       return false;
     }
   }
   return true;
 }