gn: Fix build issues blocking gfx from being built

tools/gn/ninja_binary_target_writer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/ninja_binary_target_writer.h"
 
 #include <set>
 #include <sstream>
 
 #include "base/strings/string_util.h"
@@ skipping 218 matching lines @@
 
     // All linkable deps should have a link output file.
     DCHECK(!cur->link_output_file().value().empty())
         << "No link output file for "
         << target_->label().GetUserVisibleName(false);
 
     if (cur->dependency_output_file().value() !=
         cur->link_output_file().value()) {
       // This is a shared library with separate link and deps files. Save for
       // later.
+      implicit_deps.push_back(cur->link_output_file());

[ckocagil, 2014/09/21 02:05:05]

We should implicitly depend on both the dll and the lib.

       implicit_deps.push_back(cur->dependency_output_file());
-      solibs.push_back(cur->link_output_file());
+      solibs.push_back(cur->dependency_output_file());

[ckocagil, 2014/09/21 02:05:05]

We should output the .lib here, so it can be linked.

[brettw, 2014/09/21 02:55:00]

I *think* both of these lines were correct before. Did this change a test?

On Linux, it should look like:
  foo.exe: ... | mylib.so.TOC
and this shouldn't be hit on Windows (since the link & depend output files
should be the same).

[ckocagil, 2014/09/21 11:47:27]

Done.

     } else {
       // Normal case, just link to this target.
       out_ << " ";
       path_output_.WriteFile(out_, cur->link_output_file());
     }
   }
 
   // Append implicit dependencies collected above.
   if (!implicit_deps.empty()) {
     out_ << " |";
@@ skipping 226 matching lines @@
     return false;  // No tool for this file (it's a header file or something).
   const Tool* tool = target->toolchain()->GetTool(*computed_tool_type);
   if (!tool)
     return false;  // Tool does not apply for this toolchain.file.
 
   // Figure out what output(s) this compiler produces.
   SubstitutionWriter::ApplyListToCompilerAsOutputFile(
       target, source, tool->outputs(), outputs);
   return !outputs->empty();
 }