Issue 589383003: X87: Removed superfluous deopt for ROR on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 589383003: X87: Removed superfluous deopt for ROR on ia32. (Closed)

Created:
6 years, 3 months ago by chunyang.dai

Modified:
6 years, 3 months ago

Reviewers:
Weiliang, Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

X87: Removed superfluous deopt for ROR on ia32. port r24133. On X87 this check should be unnecessary too. original commit message: Removed superfluous deopt for ROR on ia32. We only synthesize a ROR when we have an expression with a toplevel '|', which returns a signed value by definition, so deopting on negative values is not needed. ia32 was the only platform where this was done, all other didn't have the check. BUG=

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	src/x87/lithium-codegen-x87.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Committed as r24160

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages