src/x87/lithium-codegen-x87.cc - Issue 589383003: X87: Removed superfluous deopt for ROR on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/lithium-codegen-x87.cc

Issue 589383003: X87: Removed superfluous deopt for ROR on ia32. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x87/lithium-codegen-x87.cc

diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc

index ff68fd0a67296b6b0ecd31ad3e92e5492be41f5c..8e280a24438b6bd667a558b63243b829135537a8 100644

--- a/src/x87/lithium-codegen-x87.cc

+++ b/src/x87/lithium-codegen-x87.cc

@@ -1908,10 +1908,6 @@ void LCodeGen::DoShiftI(LShiftI* instr) {

switch (instr->op()) {

case Token::ROR:

__ ror_cl(ToRegister(left));

- if (instr->can_deopt()) {

- __ test(ToRegister(left), ToRegister(left));

- DeoptimizeIf(sign, instr);

- }

break;

case Token::SAR:

__ sar_cl(ToRegister(left));

« no previous file with comments | « no previous file | no next file » | no next file with comments »