Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/x87/lithium-codegen-x87.cc

Issue 589383003: X87: Removed superfluous deopt for ROR on ia32. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1890 matching lines...) Expand 10 before | Expand all | Expand 10 after
1901 LOperand* left = instr->left(); 1901 LOperand* left = instr->left();
1902 LOperand* right = instr->right(); 1902 LOperand* right = instr->right();
1903 DCHECK(left->Equals(instr->result())); 1903 DCHECK(left->Equals(instr->result()));
1904 DCHECK(left->IsRegister()); 1904 DCHECK(left->IsRegister());
1905 if (right->IsRegister()) { 1905 if (right->IsRegister()) {
1906 DCHECK(ToRegister(right).is(ecx)); 1906 DCHECK(ToRegister(right).is(ecx));
1907 1907
1908 switch (instr->op()) { 1908 switch (instr->op()) {
1909 case Token::ROR: 1909 case Token::ROR:
1910 __ ror_cl(ToRegister(left)); 1910 __ ror_cl(ToRegister(left));
1911 if (instr->can_deopt()) {
1912 __ test(ToRegister(left), ToRegister(left));
1913 DeoptimizeIf(sign, instr);
1914 }
1915 break; 1911 break;
1916 case Token::SAR: 1912 case Token::SAR:
1917 __ sar_cl(ToRegister(left)); 1913 __ sar_cl(ToRegister(left));
1918 break; 1914 break;
1919 case Token::SHR: 1915 case Token::SHR:
1920 __ shr_cl(ToRegister(left)); 1916 __ shr_cl(ToRegister(left));
1921 if (instr->can_deopt()) { 1917 if (instr->can_deopt()) {
1922 __ test(ToRegister(left), ToRegister(left)); 1918 __ test(ToRegister(left), ToRegister(left));
1923 DeoptimizeIf(sign, instr); 1919 DeoptimizeIf(sign, instr);
1924 } 1920 }
(...skipping 4313 matching lines...) Expand 10 before | Expand all | Expand 10 after
6238 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6234 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6239 RecordSafepoint(Safepoint::kNoLazyDeopt); 6235 RecordSafepoint(Safepoint::kNoLazyDeopt);
6240 } 6236 }
6241 6237
6242 6238
6243 #undef __ 6239 #undef __
6244 6240
6245 } } // namespace v8::internal 6241 } } // namespace v8::internal
6246 6242
6247 #endif // V8_TARGET_ARCH_X87 6243 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698