Properly detect whether we're running on a buildbot.

Properly detect whether we're running on a buildbot.

BUILDBOT_BUILDERNAME is only set for bots using annotated steps, which
isn't all of them. This detects whether the username is "chrome-bot"
instead.

This check is currently only being used to decide whether to use
unittest's compact VM config or the default config.

R=rnystrom@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30206

[Bob Nystrom, 2013-11-12 19:32:44]

+siggy, but LGTM.

[Siggi Cherem (dart-lang), 2013-11-12 20:05:57]

https://codereview.chromium.org/58933006/diff/1/pkg/unittest/lib/compact_vm_c...
File pkg/unittest/lib/compact_vm_config.dart (right):

https://codereview.chromium.org/58933006/diff/1/pkg/unittest/lib/compact_vm_c...
pkg/unittest/lib/compact_vm_config.dart:193: if (Platform.environment['LOGNAME']
== 'chrome-bot') {
does this work in windows/mac as well? IIRC, BUILDBOT_BUILDERNAME is used in all
platforms (true, as long as it's running annotated steps) Do you know which bots
don't use that?

[nweiz, 2013-11-12 20:11:11]

https://codereview.chromium.org/58933006/diff/1/pkg/unittest/lib/compact_vm_c...
File pkg/unittest/lib/compact_vm_config.dart (right):

https://codereview.chromium.org/58933006/diff/1/pkg/unittest/lib/compact_vm_c...
pkg/unittest/lib/compact_vm_config.dart:193: if (Platform.environment['LOGNAME']
== 'chrome-bot') {
On 2013/11/12 20:05:57, Siggi Cherem (dart-lang) wrote:
> does this work in windows/mac as well? IIRC, BUILDBOT_BUILDERNAME is used in
all
> platforms (true, as long as it's running annotated steps) Do you know which
bots
> don't use that?

According to Rico, LOGNAME should work everywhere.

It looks like none of the VM bots except cross-arm-vm-linux-release use
annotated steps.

[Siggi Cherem (dart-lang), 2013-11-12 20:23:19]

thanks for the details, lgtm

[nweiz, 2013-11-12 20:32:26]

Committed patchset #1 manually as r30206 (presubmit successful).