Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: pkg/unittest/lib/compact_vm_config.dart

Issue 58933006: Properly detect whether we're running on a buildbot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * A test configuration that generates a compact 1-line progress bar. The bar is 6 * A test configuration that generates a compact 1-line progress bar. The bar is
7 * updated in-place before and after each test is executed. If all test pass, 7 * updated in-place before and after each test is executed. If all test pass,
8 * you should only see a couple lines in the terminal. If a test fails, the 8 * you should only see a couple lines in the terminal. If a test fails, the
9 * failure is shown and the progress bar continues to be updated below it. 9 * failure is shown and the progress bar continues to be updated below it.
10 */ 10 */
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 if (firstSpace > 0) { 183 if (firstSpace > 0) {
184 res = res.substring(firstSpace); 184 res = res.substring(firstSpace);
185 } 185 }
186 return '...$res'; 186 return '...$res';
187 } 187 }
188 } 188 }
189 189
190 void useCompactVMConfiguration() { 190 void useCompactVMConfiguration() {
191 // If the test is running on the Dart buildbots, we don't want to use this 191 // If the test is running on the Dart buildbots, we don't want to use this
192 // config since it's output may not be what the bots expect. 192 // config since it's output may not be what the bots expect.
193 if (Platform.environment.containsKey('BUILDBOT_BUILDERNAME')) { 193 if (Platform.environment['LOGNAME'] == 'chrome-bot') {
Siggi Cherem (dart-lang) 2013/11/12 20:05:57 does this work in windows/mac as well? IIRC, BUILD
nweiz 2013/11/12 20:11:11 According to Rico, LOGNAME should work everywhere.
194 return; 194 return;
195 } 195 }
196 196
197 unittestConfiguration = _singleton; 197 unittestConfiguration = _singleton;
198 } 198 }
199 199
200 final _singleton = new CompactVMConfiguration(); 200 final _singleton = new CompactVMConfiguration();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698