Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: pkg/unittest/lib/compact_vm_config.dart

Issue 58933006: Properly detect whether we're running on a buildbot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/compact_vm_config.dart
diff --git a/pkg/unittest/lib/compact_vm_config.dart b/pkg/unittest/lib/compact_vm_config.dart
index 97c120a3e08d95fac6afa97562900735590516e5..7724599a398c4624b8d0d54b4c9a7ebd8795a179 100644
--- a/pkg/unittest/lib/compact_vm_config.dart
+++ b/pkg/unittest/lib/compact_vm_config.dart
@@ -190,7 +190,7 @@ class CompactVMConfiguration extends VMConfiguration {
void useCompactVMConfiguration() {
// If the test is running on the Dart buildbots, we don't want to use this
// config since it's output may not be what the bots expect.
- if (Platform.environment.containsKey('BUILDBOT_BUILDERNAME')) {
+ if (Platform.environment['LOGNAME'] == 'chrome-bot') {
Siggi Cherem (dart-lang) 2013/11/12 20:05:57 does this work in windows/mac as well? IIRC, BUILD
nweiz 2013/11/12 20:11:11 According to Rico, LOGNAME should work everywhere.
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698