Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 589243004: Update openjpeg (Closed)

Created:
6 years, 3 months ago by Bo Xu
Modified:
6 years, 2 months ago
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Patch Set 1 : Merge security fixes from openjpeg r2883 #

Total comments: 3

Patch Set 2 : Massive upgrade to openjpeg r2885 #

Patch Set 3 : Update to openjpeg r2891 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+599 lines, -461 lines) Patch
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 3 chunks +5 lines, -2 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/CMakeLists.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/cio.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/cio.c View 1 3 chunks +2 lines, -16 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/dwt.c View 1 3 chunks +5 lines, -1 line 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/function_list.c View 1 1 chunk +2 lines, -5 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/image.c View 1 1 chunk +2 lines, -4 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/j2k.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/j2k.c View 1 2 51 chunks +293 lines, -161 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.h View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c View 1 2 22 chunks +46 lines, -83 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/mct.c View 1 1 chunk +36 lines, -37 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/mqc.c View 2 chunks +6 lines, -2 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/openjpeg.h View 1 12 chunks +107 lines, -49 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/openjpeg.c View 1 9 chunks +15 lines, -13 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/opj_codec.h View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/opj_config.h View 1 1 chunk +8 lines, -6 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/opj_config.h.cmake.in View 1 1 chunk +8 lines, -0 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/opj_config_private.h View 1 1 chunk +4 lines, -22 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/opj_malloc.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/pi.c View 1 2 7 chunks +5 lines, -9 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.c View 1 3 chunks +3 lines, -2 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c View 1 2 9 chunks +20 lines, -9 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/tcd.c View 1 10 chunks +17 lines, -25 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/tgt.c View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Bo Xu
Hi Antonin, please review the CL, thanks.
6 years, 3 months ago (2014-09-24 07:40:17 UTC) #2
Tom Sepez
https://codereview.chromium.org/589243004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/openjpeg.c File core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/openjpeg.c (right): https://codereview.chromium.org/589243004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/openjpeg.c#newcode178 core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/openjpeg.c:178: l_codec->opj_dump_codec = (void (*) (void*, OPJ_INT32, FILE*)) j2k_dump; FYI: ...
6 years, 3 months ago (2014-09-24 22:33:55 UTC) #4
Tom Sepez
https://codereview.chromium.org/589243004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.c File core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.c (right): https://codereview.chromium.org/589243004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.c#newcode1166 core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.c:1166: OPJ_UINT32 datasize=w * h; This looks worrysome. Does this ...
6 years, 2 months ago (2014-09-25 19:52:05 UTC) #5
Bo Xu
On 2014/09/25 19:52:05, Tom Sepez wrote: > https://codereview.chromium.org/589243004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.c > File core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.c (right): > > https://codereview.chromium.org/589243004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.c#newcode1166 ...
6 years, 2 months ago (2014-09-30 17:32:13 UTC) #7
Tom Sepez
On 2014/09/30 17:32:13, Bo Xu wrote: > On 2014/09/25 19:52:05, Tom Sepez wrote: > > ...
6 years, 2 months ago (2014-09-30 17:33:29 UTC) #8
Bo Xu
On 2014/09/30 17:33:29, Tom Sepez wrote: > On 2014/09/30 17:32:13, Bo Xu wrote: > > ...
6 years, 2 months ago (2014-09-30 17:43:42 UTC) #9
Tom Sepez
> Thanks. I can verify the patch can fix the three issues. Maybe we can ...
6 years, 2 months ago (2014-09-30 17:44:41 UTC) #10
Bo Xu
On 2014/09/30 17:44:41, Tom Sepez wrote: > > Thanks. I can verify the patch can ...
6 years, 2 months ago (2014-09-30 17:46:20 UTC) #11
Bo Xu
6 years, 2 months ago (2014-09-30 18:12:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d53e6fdb0a86ca1ddb12876a60f7f2d7508b5349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698