Update openjpeg

core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/openjpeg.c

 /*
  * The copyright in this software is being made available under the 2-clauses 
  * BSD License, included below. This software may be subject to other third 
  * party and contributor rights, including patent rights, and no such rights
  * are granted under this license.
  *
  * Copyright (c) 2005, Herve Drolon, FreeImage Team
  * Copyright (c) 2008, 2011-2012, Centre National d'Etudes Spatiales (CNES), FR 
  * Copyright (c) 2012, CS Systemes d'Information, France
  * All rights reserved.
@@ skipping 157 matching lines @@
         l_codec = (opj_codec_private_t*) opj_calloc(1, sizeof(opj_codec_private_t));
         if (!l_codec){
                 return 00;
         }
         memset(l_codec, 0, sizeof(opj_codec_private_t));
 
         l_codec->is_decompressor = 1;
 
         switch (p_format) {
                 case OPJ_CODEC_J2K:
                         l_codec->opj_dump_codec = (void (*) (void*, OPJ_INT32, FILE*)) j2k_dump;

[Tom Sepez, 2014/09/24 22:33:55]

FYI: Theoretically, all these casts are illegal.  There's no reason to believe
the compiler will pass arguments in the same way for a function whose first
argument is of type (void*) as to a function whose first argument is of type
(struct*).  It just so happens to be the case with the computers of today.  Your
code would be correct, and cleaner, if you declared the functions to match
exaclty the expected signature, removed the casts here, and then casted to
(struct*) from (void*) inside them.

 
                         l_codec->opj_get_codec_info = (opj_codestream_info_v2_t* (*) (void*) ) j2k_get_cstr_info;
 
                         l_codec->opj_get_codec_index = (opj_codestream_index_t* (*) (void*) ) j2k_get_cstr_index;
 
                         l_codec->m_codec_data.m_decompression.opj_decode =
                                         (OPJ_BOOL (*) ( void *,
                                                                         struct opj_stream_private *,
                                                                         opj_image_t*, struct opj_event_mgr * )) opj_j2k_decode;
 
@@ skipping 378 matching lines @@
 
                         l_codec->m_codec_data.m_compression.opj_write_tile = (OPJ_BOOL (*) (void *,
                                                                                                                                                                 OPJ_UINT32,
                                                                                                                                                                 OPJ_BYTE*,
                                                                                                                                                                 OPJ_UINT32,
                                                                                                                                                                 struct opj_stream_private *,
                                                                                                                                                                 struct opj_event_mgr *) ) opj_j2k_write_tile;
 
                         l_codec->m_codec_data.m_compression.opj_destroy = (void (*) (void *)) opj_j2k_destroy;
 
-                        l_codec->m_codec_data.m_compression.opj_setup_encoder = (void (*) (     void *,
+                        l_codec->m_codec_data.m_compression.opj_setup_encoder = (OPJ_BOOL (*) ( void *,
                                                                                                                                                                 opj_cparameters_t *,
                                                                                                                                                                 struct opj_image *,
                                                                                                                                                                 struct opj_event_mgr * )) opj_j2k_setup_encoder;
 
                         l_codec->m_codec = opj_j2k_create_compress();
                         if (! l_codec->m_codec) {
                                 opj_free(l_codec);
                                 return 00;
                         }
 
@@ skipping 16 matching lines @@
 
                         l_codec->m_codec_data.m_compression.opj_write_tile = (OPJ_BOOL (*) (void *,
                                                                                                                                                                 OPJ_UINT32,
                                                                                                                                                                 OPJ_BYTE*,
                                                                                                                                                                 OPJ_UINT32,
                                                                                                                                                                 struct opj_stream_private *,
                                                                                                                                                                 struct opj_event_mgr *)) opj_jp2_write_tile;
 
                         l_codec->m_codec_data.m_compression.opj_destroy = (void (*) (void *)) opj_jp2_destroy;
 
-                        l_codec->m_codec_data.m_compression.opj_setup_encoder = (void (*) (     void *,
+                        l_codec->m_codec_data.m_compression.opj_setup_encoder = (OPJ_BOOL (*) ( void *,
                                                                                                                                                                 opj_cparameters_t *,
                                                                                                                                                                 struct opj_image *,
                                                                                                                                                                 struct opj_event_mgr * )) opj_jp2_setup_encoder;
 
                         l_codec->m_codec = opj_jp2_create(OPJ_FALSE);
                         if (! l_codec->m_codec) {
                                 opj_free(l_codec);
                                 return 00;
                         }
 
@@ skipping 326 matching lines @@
 
     opj_stream_set_user_data_v3(l_stream, p_file, (opj_stream_free_user_data_fn) fclose);
     opj_stream_set_user_data_length(l_stream, opj_get_data_length_from_file(p_file));
     opj_stream_set_read_function(l_stream, (opj_stream_read_fn) opj_read_from_file);
     opj_stream_set_write_function(l_stream, (opj_stream_write_fn) opj_write_from_file);
     opj_stream_set_skip_function(l_stream, (opj_stream_skip_fn) opj_skip_from_file);
     opj_stream_set_seek_function(l_stream, (opj_stream_seek_fn) opj_seek_from_file);
 
     return l_stream;
 }