Rename java WebContentsObserverAndroid to WebContentsObserver

Rename java WebContentsObserverAndroid to WebContentsObserver

The Java class org.chromium.content.browser.WebContentsObserverAndroid
is incorrectly named and should be WebContentsObserver to follow
the same pattern as for other classes.

The current WebContentsObserverAndroid is deprecated and it extends
new class WebContentsObserver inorder to delegate all method calls.
This is done for external repositories to adapt new class name to
WebContentsObserver after this change.

Once this is done WebContentsObserverAndroid will be removed in
next patch.

BUG=396118
Committed: https://crrev.com/9d0f48ab347adfa5f6a97de8584881562dd3d0f5
Cr-Commit-Position: refs/heads/master@{#299923}

[wajahat, 2014-09-22 13:55:37]

wajahat.s@samsung.com changed reviewers:
+ nyquist@chromium.org

[wajahat, 2014-09-22 13:55:37]

WIP Patch.

[nyquist, 2014-09-22 22:16:58]

https://codereview.chromium.org/589113002/diff/1/content/browser/android/web_...
File content/browser/android/web_contents_observer_android.h (right):

https://codereview.chromium.org/589113002/diff/1/content/browser/android/web_...
content/browser/android/web_contents_observer_android.h:84: bool
RegisterWebContentsObserver(JNIEnv* env);
I think I'd keep this name, as the native class name does not change.

https://codereview.chromium.org/589113002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
(right):

https://codereview.chromium.org/589113002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:180:
private native void nativeDestroy(long nativeWebContentsObserver);
This parameter name still needs to be nativeWebContentsObserverAndroid, as the
name of this parameter is used in the JNI generator.

Please see
https://code.google.com/p/chromium/codesearch#chromium/src/base/android/jni_g...
https://code.google.com/p/chromium/codesearch#chromium/src/base/android/jni_g...
and in general the files in
https://code.google.com/p/chromium/codesearch#chromium/src/base/android/jni_g...

https://codereview.chromium.org/589113002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
(left):

https://codereview.chromium.org/589113002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:17:
public abstract class WebContentsObserverAndroid {
Like I mentioned on the bug, I don't think you can remove this file just yet,
given there are other repositories that would break if this file goes away. You
should mark it as deprecated, and ensure it delegates calls out to the new
class.

[wajahat, 2014-09-25 11:42:13]

wajahat.s@samsung.com changed reviewers:
- nyquist@chromium.org

[wajahat, 2014-09-25 12:20:44]

wajahat.s@samsung.com changed reviewers:
+ boliu@chromium.org, jdduke@chromium.org, kolla@chromium.org,
nyquist@chromium.org, piman@chromium.org

[wajahat, 2014-09-25 12:20:46]

piman@chromium.org: Please review changes in content/content_jni.gypi

kolla@chromium.org: Please review changes in 
chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

boliu@chromium.org: Please review changes in 
android_webview/java/src/org/chromium/android_webview/AwContents.java
android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

nyquist@chromium.org: PTAL!

jdduke@chromium.org: Please review changes in 
WebContentsObserver* files

https://codereview.chromium.org/589113002/diff/1/content/browser/android/web_...
File content/browser/android/web_contents_observer_android.h (right):

https://codereview.chromium.org/589113002/diff/1/content/browser/android/web_...
content/browser/android/web_contents_observer_android.h:84: bool
RegisterWebContentsObserver(JNIEnv* env);
On 2014/09/22 22:16:57, nyquist wrote:
> I think I'd keep this name, as the native class name does not change.

Done.

https://codereview.chromium.org/589113002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
(right):

https://codereview.chromium.org/589113002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:180:
private native void nativeDestroy(long nativeWebContentsObserver);
On 2014/09/22 22:16:58, nyquist wrote:
> This parameter name still needs to be nativeWebContentsObserverAndroid, as the
> name of this parameter is used in the JNI generator.
> 
> Please see
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/android/jni_g...
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/android/jni_g...
> and in general the files in
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/android/jni_g...

Done.

https://codereview.chromium.org/589113002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
(left):

https://codereview.chromium.org/589113002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:17:
public abstract class WebContentsObserverAndroid {
On 2014/09/22 22:16:57, nyquist wrote:
> Like I mentioned on the bug, I don't think you can remove this file just yet,
> given there are other repositories that would break if this file goes away.
You
> should mark it as deprecated, and ensure it delegates calls out to the new
> class.

Done.

[wajahat, 2014-09-25 12:22:00]

PTAL! Thanks.

[jdduke (slow), 2014-09-25 14:59:41]

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
(right):

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:173:
if (mNativeWebContentsObserverAndroid != 0) {
Don't you also want to rename the native pointer? mNativeWebContentsObserver?

[wajahat, 2014-09-25 15:10:16]

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
(right):

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:173:
if (mNativeWebContentsObserverAndroid != 0) {
On 2014/09/25 14:59:41, jdduke wrote:
> Don't you also want to rename the native pointer? mNativeWebContentsObserver?
This parameter name still needs to be nativeWebContentsObserverAndroid, as the
name of this parameter is used in the JNI generator and native class is not
renamed.
https://codereview.chromium.org/589113002/#msg3

[jdduke (slow), 2014-09-25 15:46:01]

jdduke@chromium.org changed reviewers:
+ yfriedman@chromium.org

[jdduke (slow), 2014-09-25 15:46:02]

I'm only an owner for input-related changes. Adding yfriedman@ as a proper owner
for content/public/android.

[nyquist, 2014-09-25 16:57:28]

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
(right):

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:7:
import org.chromium.base.CalledByNative;
remove this and JNINamespace after you remove all the overrides.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:9:
import org.chromium.content.browser.WebContentsObserver;
They are in the same package, so this in unnecessary.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:13:
* @deprecated This class is renamed to WebContentsObserver
Could you use {@link WebContentsObserver}?
Also, just remove the old comment, and add a reference to a bug.

How about:
/**
 * @deprecated This class has been renamed to {@link }WebContentsObserver} and
will be removed when
 * all usages have been removed. See http://crbug.com/396118.
 */
@Deprecated
public abstract class ...

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:21:
@JNINamespace("content")
This annotation should not be needed anymore.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:28:
@CalledByNative
I don't think these annotations are needed anymore as this file is not processed
by the JNI generator. Also, do you need to have these methods at all?

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:29:
public void renderProcessGone(boolean wasOomProtected) {
In fact, you can just remove all the methods in this class and just keep the
constructor.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java
(right):

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java:21:
public class WebContentsObserverTest extends ContentShellTestBase {
This should match the file name.

[piman, 2014-09-25 17:02:01]

lgtm

[Yaron, 2014-09-25 22:46:16]

i'll leave the primary review to nyquist as he was planning to make this change

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
(right):

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:29:
public void renderProcessGone(boolean wasOomProtected) {
On 2014/09/25 16:57:28, nyquist wrote:
> In fact, you can just remove all the methods in this class and just keep the
> constructor.

Right. If you didn't remove them this would actually break things as
detachFromWebContents doesn't call up to its parent class which means we'd leak
the reference.

[Yaron, 2014-09-25 22:46:18]

i'll leave the primary review to nyquist as he was planning to make this change

[wajahat, 2014-09-29 14:43:25]

Thanks for comments and review !
suggestions have been incorporated in Patch Set#3
Also added changes in
https://codereview.chromium.org/589113002/diff/40001/content/browser/android/...
to generate jni only for new WebContentsObserver class.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
(right):

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:7:
import org.chromium.base.CalledByNative;
On 2014/09/25 16:57:28, nyquist wrote:
> remove this and JNINamespace after you remove all the overrides.

Done.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:9:
import org.chromium.content.browser.WebContentsObserver;
On 2014/09/25 16:57:28, nyquist wrote:
> They are in the same package, so this in unnecessary.

Done.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:13:
* @deprecated This class is renamed to WebContentsObserver
On 2014/09/25 16:57:28, nyquist wrote:
> Could you use {@link WebContentsObserver}?
> Also, just remove the old comment, and add a reference to a bug.
> 
> How about:
> /**
>  * @deprecated This class has been renamed to {@link }WebContentsObserver} and
> will be removed when
>  * all usages have been removed. See http://crbug.com/396118.
>  */
> @Deprecated
> public abstract class ...

Done.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:21:
@JNINamespace("content")
On 2014/09/25 16:57:28, nyquist wrote:
> This annotation should not be needed anymore.

Done.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:28:
@CalledByNative
On 2014/09/25 16:57:28, nyquist wrote:
> I don't think these annotations are needed anymore as this file is not
processed
> by the JNI generator. Also, do you need to have these methods at all?

Done.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:29:
public void renderProcessGone(boolean wasOomProtected) {
On 2014/09/25 16:57:28, nyquist wrote:
> In fact, you can just remove all the methods in this class and just keep the
> constructor.

Done.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:29:
public void renderProcessGone(boolean wasOomProtected) {
On 2014/09/25 22:46:16, Yaron wrote:
> On 2014/09/25 16:57:28, nyquist wrote:
> > In fact, you can just remove all the methods in this class and just keep the
> > constructor.
> 
> Right. If you didn't remove them this would actually break things as
> detachFromWebContents doesn't call up to its parent class which means we'd
leak
> the reference.

Done.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:29:
public void renderProcessGone(boolean wasOomProtected) {
On 2014/09/25 16:57:28, nyquist wrote:
> In fact, you can just remove all the methods in this class and just keep the
> constructor.

Done.

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java
(right):

https://codereview.chromium.org/589113002/diff/20001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java:21:
public class WebContentsObserverTest extends ContentShellTestBase {
On 2014/09/25 16:57:28, nyquist wrote:
> This should match the file name.
Done, reverted this change

[wajahat, 2014-09-29 14:43:50]

PTAL! Thanks.

[nyquist, 2014-10-02 21:03:26]

https://codereview.chromium.org/589113002/diff/40001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
(right):

https://codereview.chromium.org/589113002/diff/40001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:15:
* This class receives callbacks that act as hooks for various a native web
contents events related
Can you remove this description? Just keep the @deprecated javadoc above.

[nyquist, 2014-10-03 22:18:17]

FYI: I did a test-compilation and run of Chrome for Android with this change,
and it seemed to work correctly. After this is submitted, feel free to go on
with the next cleanup-CL, while we work on updating the external code repo.

[wajahat, 2014-10-07 10:29:43]

@Nyquist, Thanks for reviewing
Comments Incorporated, PTAL!

https://codereview.chromium.org/589113002/diff/40001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
(right):

https://codereview.chromium.org/589113002/diff/40001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:15:
* This class receives callbacks that act as hooks for various a native web
contents events related
On 2014/10/02 21:03:26, nyquist wrote:
> Can you remove this description? Just keep the @deprecated javadoc above.

Done.

[nyquist, 2014-10-09 15:44:57]

https://codereview.chromium.org/589113002/diff/60001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
(right):

https://codereview.chromium.org/589113002/diff/60001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:13:
public abstract class WebContentsObserverAndroid extends WebContentsObserver {
I'm sorry if I was unclear. Please add back the @Deprecated annotation here.
Other than that the change lg.

So in total it will look like this:


/**
 *  @deprecated This class has been renamed to {@link WebContentsObserver} and
 *  will be removed when all usages have been removed. See
http://crbug.com/396118.
 */
@Deprecated
public abstract class WebContentsObserverAndroid extends WebContentsObserver {
    ...

[wajahat, 2014-10-10 06:20:35]

PTAL! Thanks.

https://codereview.chromium.org/589113002/diff/60001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
(right):

https://codereview.chromium.org/589113002/diff/60001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:13:
public abstract class WebContentsObserverAndroid extends WebContentsObserver {
Adding back @Deprecated annotation, Thank you for reviewing
On 2014/10/09 15:44:56, nyquist wrote:
> I'm sorry if I was unclear. Please add back the @Deprecated annotation here.
> Other than that the change lg.
> 
> So in total it will look like this:
> 
> 
> /**
>  *  @deprecated This class has been renamed to {@link WebContentsObserver} and
>  *  will be removed when all usages have been removed. See
> http://crbug.com/396118.
>  */
> @Deprecated
> public abstract class WebContentsObserverAndroid extends WebContentsObserver {
>     ...

[wajahat, 2014-10-13 11:17:55]

ping... @nyquist
PTAL !

[nyquist, 2014-10-13 23:11:35]

this mostly lg, but could you please rebase? I'll look again tomorrow then.

Take special care about the WebContentsObserverAndroid.java ->
WebContentsObserver.java, since new changes might have come in to the original
file which you want to replicate.

https://codereview.chromium.org/589113002/diff/80001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
(right):

https://codereview.chromium.org/589113002/diff/80001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java:119:
return new TestWebContentsObserver(
I think this fits within 100 chars?

[wajahat, 2014-10-14 11:27:44]

Rebased to latest code,
Fixed spaces in InterstitialPageTest.java
PTAL!

https://codereview.chromium.org/589113002/diff/80001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
(right):

https://codereview.chromium.org/589113002/diff/80001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java:119:
return new TestWebContentsObserver(
On 2014/10/13 23:11:34, nyquist wrote:
> I think this fits within 100 chars?

Done.

[nyquist, 2014-10-14 17:15:17]

https://codereview.chromium.org/589113002/diff/320001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/589113002/diff/320001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java:80:
final WebContentsObserver webContentsObserver = new WebContentsObserver(
This fits on one line now.

https://codereview.chromium.org/589113002/diff/320001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
(right):

https://codereview.chromium.org/589113002/diff/320001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java:114:
TestWebContentsObserver observer = ThreadUtils.runOnUiThreadBlocking(
The Java code is supposed to be wrapped at 100 chars. This is not 100 chars. You
don't have to add more line wraps.

This block could be like it was before (except the name change), i.e.:

        TestWebContentsObserver observer = ThreadUtils.runOnUiThreadBlocking(
                new Callable<TestWebContentsObserver>() {
                    @Override
                    public TestWebContentsObserver call() throws Exception {
                        getWebContents().showInterstitialPage(URL,
delegate.getNative());
                        return new TestWebContentsObserver(getWebContents());
                    }
                });

https://codereview.chromium.org/589113002/diff/320001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java
(right):

https://codereview.chromium.org/589113002/diff/320001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java:62:
getContentViewCore().getWebContents());
This can be on the line above now.

[wajahat, 2014-10-15 07:15:22]

PTAL! Thanks

https://codereview.chromium.org/589113002/diff/320001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/589113002/diff/320001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java:80:
final WebContentsObserver webContentsObserver = new WebContentsObserver(
On 2014/10/14 17:15:16, nyquist wrote:
> This fits on one line now.

Done.

https://codereview.chromium.org/589113002/diff/320001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
(right):

https://codereview.chromium.org/589113002/diff/320001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java:114:
TestWebContentsObserver observer = ThreadUtils.runOnUiThreadBlocking(
On 2014/10/14 17:15:16, nyquist wrote:
> The Java code is supposed to be wrapped at 100 chars. This is not 100 chars.
You
> don't have to add more line wraps.
> 
> This block could be like it was before (except the name change), i.e.:
> 
>         TestWebContentsObserver observer = ThreadUtils.runOnUiThreadBlocking(
>                 new Callable<TestWebContentsObserver>() {
>                     @Override
>                     public TestWebContentsObserver call() throws Exception {
>                         getWebContents().showInterstitialPage(URL,
> delegate.getNative());
>                         return new TestWebContentsObserver(getWebContents());
>                     }
>                 });

Wrapping at 100 chars, Done.

https://codereview.chromium.org/589113002/diff/320001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java
(right):

https://codereview.chromium.org/589113002/diff/320001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java:62:
getContentViewCore().getWebContents());
On 2014/10/14 17:15:16, nyquist wrote:
> This can be on the line above now.

Done.

[nyquist, 2014-10-15 15:51:52]

lgtm

[boliu, 2014-10-15 17:09:08]

android_webview lgtm

[wajahat, 2014-10-16 05:22:33]

On 2014/10/15 17:09:08, boliu wrote:
> android_webview lgtm

Thanks nyquist, bollu
need another lgtm for chromecast 
@kollas, pl. do the needful, Thanks

[wajahat, 2014-10-16 05:25:12]

wajahat.s@samsung.com changed reviewers:
+ gunsch@chromium.org

[wajahat, 2014-10-16 05:26:08]

On 2014/10/16 05:22:33, wajahat wrote:
> On 2014/10/15 17:09:08, boliu wrote:
> > android_webview lgtm
> 
> Thanks nyquist, bollu
> need another lgtm for chromecast 
> @kollas, pl. do the needful, Thanks

+@gunsch/@kollas, could you pl. review changes in 
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

[gunsch, 2014-10-16 16:06:49]

chromecast/ LGTM

[wajahat, 2014-10-16 17:00:59]

The CQ bit was checked by wajahat.s@samsung.com

[commit-bot: I haz the power, 2014-10-16 17:02:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589113002/340001

[commit-bot: I haz the power, 2014-10-16 17:55:06]

Committed patchset #7 (id:340001)

[commit-bot: I haz the power, 2014-10-16 17:56:00]

Patchset 7 (id:??) landed as
https://crrev.com/9d0f48ab347adfa5f6a97de8584881562dd3d0f5
Cr-Commit-Position: refs/heads/master@{#299923}