Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 589113002: Rename java WebContentsObserverAndroid to WebContentsObserver (Closed)

Created:
6 years, 3 months ago by wajahat
Modified:
6 years, 2 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename java WebContentsObserverAndroid to WebContentsObserver The Java class org.chromium.content.browser.WebContentsObserverAndroid is incorrectly named and should be WebContentsObserver to follow the same pattern as for other classes. The current WebContentsObserverAndroid is deprecated and it extends new class WebContentsObserver inorder to delegate all method calls. This is done for external repositories to adapt new class name to WebContentsObserver after this change. Once this is done WebContentsObserverAndroid will be removed in next patch. BUG=396118 Committed: https://crrev.com/9d0f48ab347adfa5f6a97de8584881562dd3d0f5 Cr-Commit-Position: refs/heads/master@{#299923}

Patch Set 1 #

Total comments: 6

Patch Set 2 : changes incorporated #

Total comments: 19

Patch Set 3 : #

Total comments: 2

Patch Set 4 : changes incorporated in WebContentsObserverAndroid #

Total comments: 2

Patch Set 5 : Adding back @Deprecated annotation to WebContentsObserverAndroid class #

Total comments: 2

Patch Set 6 : rebased #

Total comments: 6

Patch Set 7 : style issues fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -243 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/VoiceSearchTabHelper.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/web_contents_observer_android.cc View 1 2 3 4 5 17 chunks +17 lines, -17 lines 0 comments Download
M content/content_jni.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java View 1 2 3 4 5 1 chunk +5 lines, -182 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java View 1 2 3 4 5 6 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java View 1 2 3 4 5 6 2 chunks +7 lines, -8 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 37 (6 generated)
wajahat
WIP Patch.
6 years, 3 months ago (2014-09-22 13:55:37 UTC) #2
nyquist
https://codereview.chromium.org/589113002/diff/1/content/browser/android/web_contents_observer_android.h File content/browser/android/web_contents_observer_android.h (right): https://codereview.chromium.org/589113002/diff/1/content/browser/android/web_contents_observer_android.h#newcode84 content/browser/android/web_contents_observer_android.h:84: bool RegisterWebContentsObserver(JNIEnv* env); I think I'd keep this name, ...
6 years, 3 months ago (2014-09-22 22:16:58 UTC) #3
wajahat
piman@chromium.org: Please review changes in content/content_jni.gypi kolla@chromium.org: Please review changes in chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java boliu@chromium.org: Please review ...
6 years, 2 months ago (2014-09-25 12:20:46 UTC) #6
wajahat
PTAL! Thanks.
6 years, 2 months ago (2014-09-25 12:22:00 UTC) #7
jdduke (slow)
https://codereview.chromium.org/589113002/diff/20001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java File content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java (right): https://codereview.chromium.org/589113002/diff/20001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java#newcode173 content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:173: if (mNativeWebContentsObserverAndroid != 0) { Don't you also want ...
6 years, 2 months ago (2014-09-25 14:59:41 UTC) #8
wajahat
https://codereview.chromium.org/589113002/diff/20001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java File content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java (right): https://codereview.chromium.org/589113002/diff/20001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java#newcode173 content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:173: if (mNativeWebContentsObserverAndroid != 0) { On 2014/09/25 14:59:41, jdduke ...
6 years, 2 months ago (2014-09-25 15:10:16 UTC) #9
jdduke (slow)
I'm only an owner for input-related changes. Adding yfriedman@ as a proper owner for content/public/android.
6 years, 2 months ago (2014-09-25 15:46:02 UTC) #11
nyquist
https://codereview.chromium.org/589113002/diff/20001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java File content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java (right): https://codereview.chromium.org/589113002/diff/20001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java#newcode7 content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:7: import org.chromium.base.CalledByNative; remove this and JNINamespace after you remove ...
6 years, 2 months ago (2014-09-25 16:57:28 UTC) #12
piman
lgtm
6 years, 2 months ago (2014-09-25 17:02:01 UTC) #13
Yaron
i'll leave the primary review to nyquist as he was planning to make this change ...
6 years, 2 months ago (2014-09-25 22:46:16 UTC) #14
Yaron
i'll leave the primary review to nyquist as he was planning to make this change
6 years, 2 months ago (2014-09-25 22:46:18 UTC) #15
wajahat
Thanks for comments and review ! suggestions have been incorporated in Patch Set#3 Also added ...
6 years, 2 months ago (2014-09-29 14:43:25 UTC) #16
wajahat
PTAL! Thanks.
6 years, 2 months ago (2014-09-29 14:43:50 UTC) #17
nyquist
https://codereview.chromium.org/589113002/diff/40001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java File content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java (right): https://codereview.chromium.org/589113002/diff/40001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java#newcode15 content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:15: * This class receives callbacks that act as hooks ...
6 years, 2 months ago (2014-10-02 21:03:26 UTC) #18
nyquist
FYI: I did a test-compilation and run of Chrome for Android with this change, and ...
6 years, 2 months ago (2014-10-03 22:18:17 UTC) #19
wajahat
@Nyquist, Thanks for reviewing Comments Incorporated, PTAL! https://codereview.chromium.org/589113002/diff/40001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java File content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java (right): https://codereview.chromium.org/589113002/diff/40001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java#newcode15 content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:15: * This ...
6 years, 2 months ago (2014-10-07 10:29:43 UTC) #20
nyquist
https://codereview.chromium.org/589113002/diff/60001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java File content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java (right): https://codereview.chromium.org/589113002/diff/60001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java#newcode13 content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:13: public abstract class WebContentsObserverAndroid extends WebContentsObserver { I'm sorry ...
6 years, 2 months ago (2014-10-09 15:44:57 UTC) #21
wajahat
PTAL! Thanks. https://codereview.chromium.org/589113002/diff/60001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java File content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java (right): https://codereview.chromium.org/589113002/diff/60001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java#newcode13 content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:13: public abstract class WebContentsObserverAndroid extends WebContentsObserver { ...
6 years, 2 months ago (2014-10-10 06:20:35 UTC) #22
wajahat
ping... @nyquist PTAL !
6 years, 2 months ago (2014-10-13 11:17:55 UTC) #23
nyquist
this mostly lg, but could you please rebase? I'll look again tomorrow then. Take special ...
6 years, 2 months ago (2014-10-13 23:11:35 UTC) #24
wajahat
Rebased to latest code, Fixed spaces in InterstitialPageTest.java PTAL! https://codereview.chromium.org/589113002/diff/80001/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java File content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java (right): https://codereview.chromium.org/589113002/diff/80001/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java#newcode119 content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java:119: ...
6 years, 2 months ago (2014-10-14 11:27:44 UTC) #25
nyquist
https://codereview.chromium.org/589113002/diff/320001/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java File chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java (right): https://codereview.chromium.org/589113002/diff/320001/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java#newcode80 chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java:80: final WebContentsObserver webContentsObserver = new WebContentsObserver( This fits on ...
6 years, 2 months ago (2014-10-14 17:15:17 UTC) #26
wajahat
PTAL! Thanks https://codereview.chromium.org/589113002/diff/320001/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java File chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java (right): https://codereview.chromium.org/589113002/diff/320001/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java#newcode80 chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java:80: final WebContentsObserver webContentsObserver = new WebContentsObserver( On ...
6 years, 2 months ago (2014-10-15 07:15:22 UTC) #27
nyquist
lgtm
6 years, 2 months ago (2014-10-15 15:51:52 UTC) #28
boliu
android_webview lgtm
6 years, 2 months ago (2014-10-15 17:09:08 UTC) #29
wajahat
On 2014/10/15 17:09:08, boliu wrote: > android_webview lgtm Thanks nyquist, bollu need another lgtm for ...
6 years, 2 months ago (2014-10-16 05:22:33 UTC) #30
wajahat
On 2014/10/16 05:22:33, wajahat wrote: > On 2014/10/15 17:09:08, boliu wrote: > > android_webview lgtm ...
6 years, 2 months ago (2014-10-16 05:26:08 UTC) #32
gunsch
chromecast/ LGTM
6 years, 2 months ago (2014-10-16 16:06:49 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589113002/340001
6 years, 2 months ago (2014-10-16 17:02:26 UTC) #35
commit-bot: I haz the power
Committed patchset #7 (id:340001)
6 years, 2 months ago (2014-10-16 17:55:06 UTC) #36
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 17:56:00 UTC) #37
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/9d0f48ab347adfa5f6a97de8584881562dd3d0f5
Cr-Commit-Position: refs/heads/master@{#299923}

Powered by Google App Engine
This is Rietveld 408576698