content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java - Issue 589113002: Rename java WebContentsObserverAndroid to WebContentsObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

Issue 589113002: Rename java WebContentsObserverAndroid to WebContentsObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: style issues fixed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java b/content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

index e5084a37ec41723156213dab061d8b556b4c0ec2..b5ed7bf9091ff7e3d9f9be86f82efb1053c48de1 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

@@ -16,16 +16,16 @@ import org.chromium.content_shell_apk.ContentShellTestBase;

import java.util.concurrent.Callable;

/**

- * Tests for the WebContentsObserverAndroid APIs.

+ * Tests for the WebContentsObserver APIs.

public class WebContentsObserverAndroidTest extends ContentShellTestBase {

private static final String URL = UrlUtils.encodeHtmlDataUri(

"<html><head></head><body>didFirstVisuallyNonEmptyPaint test</body></html>");

- private static class TestWebContentsObserverAndroid extends WebContentsObserverAndroid {

+ private static class TestWebContentsObserver extends WebContentsObserver {

private CallbackHelper mDidFirstVisuallyNonEmptyPaintCallbackHelper = new CallbackHelper();

- public TestWebContentsObserverAndroid(WebContents webContents) {

+ public TestWebContentsObserver(WebContents webContents) {

super(webContents);

}

@@ -54,12 +54,11 @@ public class WebContentsObserverAndroidTest extends ContentShellTestBase {

@DisabledTest

public void testDidFirstVisuallyNonEmptyPaint() throws Throwable {

- TestWebContentsObserverAndroid observer = ThreadUtils.runOnUiThreadBlocking(

- new Callable<TestWebContentsObserverAndroid>() {

+ TestWebContentsObserver observer = ThreadUtils.runOnUiThreadBlocking(

+ new Callable<TestWebContentsObserver>() {

@Override

- public TestWebContentsObserverAndroid call() throws Exception {

- return new TestWebContentsObserverAndroid(

- getContentViewCore().getWebContents());

+ public TestWebContentsObserver call() throws Exception {

+ return new TestWebContentsObserver(getContentViewCore().getWebContents());

}

});