content/browser/android/web_contents_observer_android.h - Issue 589113002: Rename java WebContentsObserverAndroid to WebContentsObserver

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/android/web_contents_observer_android.h

Issue 589113002: Rename java WebContentsObserverAndroid to WebContentsObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/android/browser_jni_registrar.cc ('k') | content/browser/android/web_contents_observer_android.cc » ('j') | content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_ANDROID_WEB_CONTENTS_OBSERVER_ANDROID_H_	5 #ifndef CONTENT_BROWSER_ANDROID_WEB_CONTENTS_OBSERVER_ANDROID_H_

6 #define CONTENT_BROWSER_ANDROID_WEB_CONTENTS_OBSERVER_ANDROID_H_	6 #define CONTENT_BROWSER_ANDROID_WEB_CONTENTS_OBSERVER_ANDROID_H_

7	7

8 #include <jni.h>	8 #include <jni.h>

9	9

10 #include "base/android/jni_weak_ref.h"	10 #include "base/android/jni_weak_ref.h"

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
74 bool is_main_frame,	74 bool is_main_frame,

75 int error_code,	75 int error_code,

76 const base::string16& description,	76 const base::string16& description,

77 const GURL& url);	77 const GURL& url);

78	78

79 JavaObjectWeakGlobalRef weak_java_observer_;	79 JavaObjectWeakGlobalRef weak_java_observer_;

80	80

81 DISALLOW_COPY_AND_ASSIGN(WebContentsObserverAndroid);	81 DISALLOW_COPY_AND_ASSIGN(WebContentsObserverAndroid);

82 };	82 };

83	83

84 bool RegisterWebContentsObserverAndroid(JNIEnv* env);	84 bool RegisterWebContentsObserver(JNIEnv* env);
	nyquist 2014/09/22 22:16:57 I think I'd keep this name, as the native class na I think I'd keep this name, as the native class name does not change. wajahat 2014/09/25 12:20:46 Done. Show quoted text On 2014/09/22 22:16:57, nyquist wrote: > I think I'd keep this name, as the native class name does not change. Done.
85 } // namespace content	85 } // namespace content

86	86

87 #endif // CONTENT_BROWSER_ANDROID_WEB_CONTENTS_OBSERVER_ANDROID_H_	87 #endif // CONTENT_BROWSER_ANDROID_WEB_CONTENTS_OBSERVER_ANDROID_H_

OLD	NEW