Adding support for ARIA 1.1 role="none"

Adding support for ARIA 1.1 role="none"

In ARIA 1.1, the working group plans to introduce 'none' as a synonym to the 'presentation' role,
due to author confusion surrounding the intended meaning of the word "presentation" or "presentational."
Many individuals erroneously consider role="presentation" to be synonymous with aria-hidden="true",
and we believe role="none" conveys the actual meaning more unambiguously.

After considerable time, aria role presentation would be deprecated out.

BUG=385070
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182472

[shreeramk, 2014-09-20 12:39:35]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org, dtseng@google.com

[shreeramk, 2014-09-20 12:39:36]

Please suggest the changes given in the comments.

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXObject.cpp:300: if
(isNoneOrPresentationalChildOfAriaRole())
same query as mentioned in AXObject.h

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXObject.h (right):

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXObject.h:438: virtual bool
ariaRoleHasNoneOrPresentationalChildren() const { return false; }
Should I go ahead with above modified function name or modify it to
ariaRoleHasNoneChildren?

Since presentation would be deprecated.

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXObject.h:440: virtual bool
isNoneOrPresentationalChildOfAriaRole() const { return false; }
Should I go ahead with above modified function name or modify it to
isNoneChildOfAriaRole?

Since presentation would be deprecated.

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXRenderObject.cpp (right):

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXRenderObject.cpp:999: bool
AXRenderObject::ariaRoleHasNoneOrPresentationalChildren() const
Same query as AXObject.h

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXRenderObject.cpp:2277: bool
AXRenderObject::inheritsNoneOrPresentationalRole() const
Same query as AXRenderObject.h

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXRenderObject.h (right):

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXRenderObject.h:133: virtual bool
isNoneOrPresentationalChildOfAriaRole() const OVERRIDE;
Same query as AXObject.h.

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXRenderObject.h:229: bool
inheritsNoneOrPresentationalRole() const;
Should I go ahead with above modified function name or modify it to
inheritsNoneRole?

Since presentation would be deprecated.

[dmazzoni, 2014-09-22 06:12:23]

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXObject.h (right):

https://codereview.chromium.org/588653003/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXObject.h:438: virtual bool
ariaRoleHasNoneOrPresentationalChildren() const { return false; }
On 2014/09/20 12:39:36, shreeram.k wrote:
> Should I go ahead with above modified function name or modify it to
> ariaRoleHasNoneChildren?
> 
> Since presentation would be deprecated.

My vote is to leave it alone - ariaRoleHasPresentationalChildren - the word
"presentational" can just mean has role="presentation" or role="none".

https://codereview.chromium.org/588653003/diff/20001/Source/web/AssertMatchin...
File Source/web/AssertMatchingEnums.cpp (right):

https://codereview.chromium.org/588653003/diff/20001/Source/web/AssertMatchin...
Source/web/AssertMatchingEnums.cpp:237:
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleNone, NoneRole);
nit: sort this

[shreeramk, 2014-09-22 06:18:25]

Also I had written one mail to you regarding the problem that I am facing on
Chromium side while adding "none" role. Any inputs on that?

On 2014/09/22 06:12:23, dmazzoni wrote:
> My vote is to leave it alone - ariaRoleHasPresentationalChildren - the word
> "presentational" can just mean has role="presentation" or role="none".

Ok. I ll leave this like that.

[shreeramk, 2014-09-22 14:38:23]

PTAL!

[dmazzoni, 2014-09-22 15:37:42]

Please add a test also.

No need to get creative - you could just duplicate
LayoutTests/accessibility/aria-presentational-role.html

[shreeramk, 2014-09-23 06:05:43]

PTAL!

On 2014/09/22 15:37:42, dmazzoni wrote:
> Please add a test also.
> 
> No need to get creative - you could just duplicate
> LayoutTests/accessibility/aria-presentational-role.html

LayoutTest added for aria role none.

[dmazzoni, 2014-09-23 06:43:47]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-09-23 06:43:48]

lgtm

[commit-bot: I haz the power, 2014-09-23 06:44:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588653003/60001

[commit-bot: I haz the power, 2014-09-23 07:16:57]

Committed patchset #4 (id:60001) as 182472