Source/core/accessibility/AXNodeObject.cpp - Issue 588653003: Adding support for ARIA 1.1 role="none"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 588653003: Adding support for ARIA 1.1 role="none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding Layout Test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AXNodeObject.cpp

diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp

index 7f663aa8817b6fbc4f92b07476e72f44139da862..6705943655a3b77abf87595f4c812712dc42e2a9 100644

--- a/Source/core/accessibility/AXNodeObject.cpp

+++ b/Source/core/accessibility/AXNodeObject.cpp

@@ -245,7 +245,7 @@ AccessibilityRole AXNodeObject::determineAriaRoleAttribute() const

AccessibilityRole role = ariaRoleToWebCoreRole(ariaRole);

// ARIA states if an item can get focus, it should not be presentational.

- if (role == PresentationalRole && canSetFocusAttribute())

+ if ((role == NoneRole || role == PresentationalRole) && canSetFocusAttribute())

return UnknownRole;

if (role == ButtonRole)