Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 588653003: Adding support for ARIA 1.1 role="none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding Layout Test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/accessibility/AXObject.cpp ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXRenderObject.cpp
diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp
index 05c40804f5ff5fb854cd1445ab2f7325e8b6ff48..f6e6c036196c0a5aec88121f17b24eaa2215d14a 100644
--- a/Source/core/accessibility/AXRenderObject.cpp
+++ b/Source/core/accessibility/AXRenderObject.cpp
@@ -598,7 +598,7 @@ bool AXRenderObject::computeAccessibilityIsIgnored() const
if (roleValue() == IgnoredRole)
return true;
- if (roleValue() == PresentationalRole || inheritsPresentationalRole())
+ if ((roleValue() == NoneRole || roleValue() == PresentationalRole) || inheritsPresentationalRole())
return true;
// An ARIA tree can only have tree items and static text as children.
@@ -2296,7 +2296,7 @@ bool AXRenderObject::inheritsPresentationalRole() const
QualifiedName tagName = toElement(elementNode)->tagQName();
if (tagName == ulTag || tagName == olTag || tagName == dlTag)
- return parent->roleValue() == PresentationalRole;
+ return (parent->roleValue() == NoneRole || parent->roleValue() == PresentationalRole);
return false;
}
« no previous file with comments | « Source/core/accessibility/AXObject.cpp ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698