Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 588233002: Fix lifetime of EnhancedBookmarkModel & BookmarkImageService (Closed)

Created:
6 years, 2 months ago by sdefresne
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix lifetime of EnhancedBookmarkModel & BookmarkImageService Unregister BookmarkImageService observer from BookmarkModel in the Shutdown method instead of the destructor to follow the two step shutdown of the profile. Fix a typo in the EnhancedBookmarkModel override of KeyedService Shutdown method (could have been caught by using the OVERRIDE keyword). BUG=None Committed: https://crrev.com/80f52c68fbd705cde1f35866998540fb3e60f126 Cr-Commit-Position: refs/heads/master@{#296009}

Patch Set 1 #

Patch Set 2 : Fix compilation of unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M components/enhanced_bookmarks/bookmark_image_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_image_service.cc View 1 chunk +6 lines, -1 line 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model.h View 1 chunk +1 line, -1 line 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sdefresne
PTAL
6 years, 2 months ago (2014-09-22 16:21:14 UTC) #2
noyau (Ping after 24h)
lgtm
6 years, 2 months ago (2014-09-22 16:21:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588233002/1
6 years, 2 months ago (2014-09-22 16:22:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17168) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/17736)
6 years, 2 months ago (2014-09-22 16:29:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588233002/20001
6 years, 2 months ago (2014-09-22 16:48:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b18d07efe95205befd785a38ee40553f2c94e393
6 years, 2 months ago (2014-09-22 17:49:51 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-22 17:50:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80f52c68fbd705cde1f35866998540fb3e60f126
Cr-Commit-Position: refs/heads/master@{#296009}

Powered by Google App Engine
This is Rietveld 408576698