components/enhanced_bookmarks/enhanced_bookmark_model.h - Issue 588233002: Fix lifetime of EnhancedBookmarkModel & BookmarkImageService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_model.h

Issue 588233002: Fix lifetime of EnhancedBookmarkModel & BookmarkImageService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation of unittests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/enhanced_bookmarks/bookmark_image_service.cc ('k') | components/enhanced_bookmarks/enhanced_bookmark_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/enhanced_bookmarks/enhanced_bookmark_model.h

diff --git a/components/enhanced_bookmarks/enhanced_bookmark_model.h b/components/enhanced_bookmarks/enhanced_bookmark_model.h

index 1a661c055c62a8feed3c9676034176a1685702df..c3729858981e0c5634f3253248683b3e4ef4fb03 100644

--- a/components/enhanced_bookmarks/enhanced_bookmark_model.h

+++ b/components/enhanced_bookmarks/enhanced_bookmark_model.h

@@ -38,7 +38,7 @@ class EnhancedBookmarkModel : public KeyedService,

const std::string& version);

virtual ~EnhancedBookmarkModel();

- virtual void ShutDown();

+ virtual void Shutdown() OVERRIDE;

void AddObserver(EnhancedBookmarkModelObserver* observer);

void RemoveObserver(EnhancedBookmarkModelObserver* observer);