Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: components/enhanced_bookmarks/bookmark_image_service.cc

Issue 588233002: Fix lifetime of EnhancedBookmarkModel & BookmarkImageService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation of unittests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/enhanced_bookmarks/bookmark_image_service.cc
diff --git a/components/enhanced_bookmarks/bookmark_image_service.cc b/components/enhanced_bookmarks/bookmark_image_service.cc
index e481bce8c0873c2ee4f03ec044df4ba4611bba3f..066d9f93caedfa85dca7f347577069bf1968f6d6 100644
--- a/components/enhanced_bookmarks/bookmark_image_service.cc
+++ b/components/enhanced_bookmarks/bookmark_image_service.cc
@@ -83,13 +83,18 @@ BookmarkImageService::BookmarkImageService(
BookmarkImageService::~BookmarkImageService() {
DCHECK(CalledOnValidThread());
- enhanced_bookmark_model_->bookmark_model()->RemoveObserver(this);
pool_->PostNamedSequencedWorkerTask(
kSequenceToken,
FROM_HERE,
base::Bind(&DeleteImageStore, store_.release()));
}
+void BookmarkImageService::Shutdown() {
+ DCHECK(CalledOnValidThread());
+ enhanced_bookmark_model_->bookmark_model()->RemoveObserver(this);
+ enhanced_bookmark_model_ = NULL;
+}
+
void BookmarkImageService::SalientImageForUrl(const GURL& page_url,
Callback callback) {
DCHECK(CalledOnValidThread());
« no previous file with comments | « components/enhanced_bookmarks/bookmark_image_service.h ('k') | components/enhanced_bookmarks/enhanced_bookmark_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698