ui/views/controls/native/native_view_host.cc - Issue 588113002: Change Widget::GetAllOwnedWidgets to return child widgets as well

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/native/native_view_host.cc

Issue 588113002: Change Widget::GetAllOwnedWidgets to return child widgets as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aid_resilient_to_uninstall_and_profile_changes

Patch Set: Merged GetAllChildWidgets and GetAllOwnedWidgets Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/native/native_view_host.cc

diff --git a/ui/views/controls/native/native_view_host.cc b/ui/views/controls/native/native_view_host.cc

index d706fc3dc4a8c4ebd8e1d6b0b86828aa4625aa86..2de8b13f4f314a48194a9fd20abfa8a6d0cfa3f7 100644

--- a/ui/views/controls/native/native_view_host.cc

+++ b/ui/views/controls/native/native_view_host.cc

@@ -212,7 +212,7 @@ void NativeViewHost::ClearFocus() {

return;

Widget::Widgets widgets;

- Widget::GetAllChildWidgets(native_view(), &widgets);

+ Widget::GetAllChildAndOwnedWidgets(native_view(), &widgets);

sky 2014/10/23 02:29:18 GAH! Sorry, didn't realize these other windows don

for (Widget::Widgets::iterator i = widgets.begin(); i != widgets.end(); ++i) {

focus_manager->ViewRemoved((*i)->GetRootView());

if (!focus_manager->GetFocusedView())

« no previous file with comments | « ui/views/accessibility/native_view_accessibility_win.cc ('k') | ui/views/controls/native/native_view_host_mac.mm » ('j') | no next file with comments »