ui/views/controls/native/native_view_host_mac.mm - Issue 588113002: Change Widget::GetAllOwnedWidgets to return child widgets as well

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/native/native_view_host_mac.mm

Issue 588113002: Change Widget::GetAllOwnedWidgets to return child widgets as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aid_resilient_to_uninstall_and_profile_changes

Patch Set: Merged GetAllChildWidgets and GetAllOwnedWidgets Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/native/native_view_host_mac.mm

diff --git a/ui/views/controls/native/native_view_host_mac.mm b/ui/views/controls/native/native_view_host_mac.mm

index 2858508de81dfdea065f9bcad7ef26e2abcd439c..88581c276c1aba40b94d3269d9bf2c95c0cbec58 100644

--- a/ui/views/controls/native/native_view_host_mac.mm

+++ b/ui/views/controls/native/native_view_host_mac.mm

@@ -26,7 +26,7 @@ void ReparentNSView(NSView* native_view, Widget* new_parent) {

// might want to associate with the hosted NSView instead.

{

Widget::Widgets child_widgets;

- Widget::GetAllChildWidgets(native_view, &child_widgets);

+ Widget::GetAllChildAndOwnedWidgets(native_view, &child_widgets);

CHECK_GE(1u, child_widgets.size()); // 1 (itself) or 0 if detached.

}

« ui/views/controls/native/native_view_host.cc ('K') | « ui/views/controls/native/native_view_host.cc ('k') | ui/views/widget/native_widget_aura.cc » ('j') | no next file with comments »