ui/views/accessibility/native_view_accessibility_win.cc - Issue 588113002: Change Widget::GetAllOwnedWidgets to return child widgets as well

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/native_view_accessibility_win.cc

Issue 588113002: Change Widget::GetAllOwnedWidgets to return child widgets as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aid_resilient_to_uninstall_and_profile_changes

Patch Set: Merged GetAllChildWidgets and GetAllOwnedWidgets Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_views_browsertest.cc ('k') | ui/views/controls/native/native_view_host.cc » ('j') | ui/views/controls/native/native_view_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/accessibility/native_view_accessibility_win.cc

diff --git a/ui/views/accessibility/native_view_accessibility_win.cc b/ui/views/accessibility/native_view_accessibility_win.cc

index 023e31188e3b86e52d0cf58b05195f8c031d2b2f..fb77514040eb708645d328031fe608157212d393 100644

--- a/ui/views/accessibility/native_view_accessibility_win.cc

+++ b/ui/views/accessibility/native_view_accessibility_win.cc

@@ -1491,8 +1491,7 @@ void NativeViewAccessibilityWin::PopulateChildWidgetVector(

return;

std::set<Widget*> child_widgets;

- Widget::GetAllChildWidgets(widget->GetNativeView(), &child_widgets);

- Widget::GetAllOwnedWidgets(widget->GetNativeView(), &child_widgets);

+ Widget::GetAllChildAndOwnedWidgets(widget->GetNativeView(), &child_widgets);

for (std::set<Widget*>::const_iterator iter = child_widgets.begin();

iter != child_widgets.end(); ++iter) {

Widget* child_widget = *iter;