Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: chrome/browser/ui/app_list/app_list_service_views_browsertest.cc

Issue 588113002: Change Widget::GetAllOwnedWidgets to return child widgets as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aid_resilient_to_uninstall_and_profile_changes
Patch Set: Merged GetAllChildWidgets and GetAllOwnedWidgets Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_service_views_browsertest.cc
diff --git a/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc b/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc
index 44ab3bbc1a879b2b70ffeee680dc1def1c742356..5d64a59a0d2e7812f213cacfc49ef6322fcc583b 100644
--- a/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc
+++ b/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc
@@ -125,9 +125,8 @@ IN_PROC_BROWSER_TEST_F(AppListServiceViewsBrowserTest, AcceleratorClose) {
typedef ExtensionBrowserTest AppListControllerAppInfoDialogBrowserTest;
// Test the DoShowAppInfoFlow function of the controller delegate.
-// flaky: http://crbug.com/378251
IN_PROC_BROWSER_TEST_F(AppListControllerAppInfoDialogBrowserTest,
- DISABLED_DoShowAppInfoFlow) {
+ DoShowAppInfoFlow) {
// Install an extension to open the dialog for.
base::FilePath test_extension_path;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_extension_path));
@@ -152,7 +151,7 @@ IN_PROC_BROWSER_TEST_F(AppListControllerAppInfoDialogBrowserTest,
// Open the app info dialog.
views::Widget::Widgets owned_widgets;
- views::Widget::GetAllOwnedWidgets(native_view, &owned_widgets);
+ views::Widget::GetAllChildAndOwnedWidgets(native_view, &owned_widgets);
EXPECT_EQ(0U, owned_widgets.size());
EXPECT_FALSE(test_api.is_overlay_visible());
@@ -162,7 +161,7 @@ IN_PROC_BROWSER_TEST_F(AppListControllerAppInfoDialogBrowserTest,
controller->DoShowAppInfoFlow(browser()->profile(), extension->id());
owned_widgets.clear();
- views::Widget::GetAllOwnedWidgets(native_view, &owned_widgets);
+ views::Widget::GetAllChildAndOwnedWidgets(native_view, &owned_widgets);
EXPECT_EQ(1U, owned_widgets.size());
EXPECT_TRUE(test_api.is_overlay_visible());
@@ -171,7 +170,7 @@ IN_PROC_BROWSER_TEST_F(AppListControllerAppInfoDialogBrowserTest,
app_info_dialog->CloseNow();
owned_widgets.clear();
- views::Widget::GetAllOwnedWidgets(native_view, &owned_widgets);
+ views::Widget::GetAllChildAndOwnedWidgets(native_view, &owned_widgets);
EXPECT_EQ(0U, owned_widgets.size());
EXPECT_FALSE(test_api.is_overlay_visible());
}
« no previous file with comments | « no previous file | ui/views/accessibility/native_view_accessibility_win.cc » ('j') | ui/views/controls/native/native_view_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698