[Athena: Cleanup] consolidate ChromeAppActivity and ShellAppActivity

As both now uses AppWindow

BUG=None
TBR=yoz@chromium.org

Committed: https://crrev.com/685ccea874df9b5f47665aac007bbc876d344938
Cr-Commit-Position: refs/heads/master@{#295986}

[oshima, 2014-09-20 00:57:12]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2014-09-20 01:13:15]

Patchset #2 (id:20001) has been deleted

[oshima, 2014-09-20 01:13:18]

Patchset #1 (id:1) has been deleted

[Jun Mukai, 2014-09-20 04:33:32]

You can also remove content_activity_factory_creator, and simply move the
content_activity_factory.h to public (and let main creating it directly).

https://codereview.chromium.org/587953002/diff/40001/athena/content/DEPS
File athena/content/DEPS (right):

https://codereview.chromium.org/587953002/diff/40001/athena/content/DEPS#newc...
athena/content/DEPS:14: "+extensions/browser/app_window/app_window.h",
This is an unfortunate historical effect, I think ideally app_window users would
be in athena/extensions instead.

We cannot do that right now, but could you add a TODO here?  It's okay to assign
to me.

[oshima, 2014-09-20 10:53:48]

On 2014/09/20 04:33:32, Jun Mukai wrote:
> You can also remove content_activity_factory_creator, and simply move the
> content_activity_factory.h to public (and let main creating it directly).

There is no need to expose the header, so I'd rather leave it as is.
(WebContentsViewDelegate is doing the same)

> 
> https://codereview.chromium.org/587953002/diff/40001/athena/content/DEPS
> File athena/content/DEPS (right):
> 
>
https://codereview.chromium.org/587953002/diff/40001/athena/content/DEPS#newc...
> athena/content/DEPS:14: "+extensions/browser/app_window/app_window.h",
> This is an unfortunate historical effect, I think ideally app_window users
would
> be in athena/extensions instead.
> 
> We cannot do that right now, but could you add a TODO here?  It's okay to
assign
> to me.

I agree, and I think we can do it now (but not in this CL). I added TODO in
app_activit.h

[Jun Mukai, 2014-09-20 20:24:23]

lgtm

[oshima, 2014-09-22 15:20:11]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-22 15:21:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/587953002/60001

[commit-bot: I haz the power, 2014-09-22 15:30:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 15:30:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2014-09-22 16:23:42]

oshima@chromium.org changed reviewers:
+ yoz@chromium.org

[oshima, 2014-09-22 16:24:59]

tbr'ing yoz for moving app_window.h dependency frmo athena/content/chrome/DEPS
to athena/content/DEPS

[oshima, 2014-09-22 16:25:02]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-22 16:27:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/587953002/60001

[commit-bot: I haz the power, 2014-09-22 16:34:40]

Committed patchset #2 (id:60001) as 479852292279287e1e74f2a95bdc684b3b56ebde

[commit-bot: I haz the power, 2014-09-22 16:35:24]

Patchset 2 (id:??) landed as
https://crrev.com/685ccea874df9b5f47665aac007bbc876d344938
Cr-Commit-Position: refs/heads/master@{#295986}