Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: athena/content/chrome/content_activity_factory.cc

Issue 587953002: [Athena: Cleanup] consolidate ChromeAppActivity and ShellAppActivity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/content/chrome/DEPS ('k') | athena/content/content_activity_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/content/chrome/content_activity_factory.cc
diff --git a/athena/content/chrome/content_activity_factory.cc b/athena/content/chrome/content_activity_factory.cc
deleted file mode 100644
index f3c9592ce07991dda9adadd105b3211f656ce179..0000000000000000000000000000000000000000
--- a/athena/content/chrome/content_activity_factory.cc
+++ /dev/null
@@ -1,56 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "athena/content/content_activity_factory.h"
-
-#include "athena/content/app_activity.h"
-#include "extensions/browser/app_window/app_window.h"
-#include "ui/views/controls/webview/webview.h"
-
-// TODO(oshima): Consolidate this and app shell implementation once
-// crbug.com/403726 is fixed.
-namespace athena {
-namespace {
-
-class ChromeAppActivity : public AppActivity {
- public:
- ChromeAppActivity(extensions::AppWindow* app_window, views::WebView* web_view)
- : AppActivity(app_window->extension_id()),
- app_window_(app_window),
- web_view_(web_view) {
- DCHECK_EQ(app_window->web_contents(), web_view->GetWebContents());
- Observe(app_window_->web_contents());
- }
-
- private:
- virtual ~ChromeAppActivity() {}
-
- // ActivityViewModel overrides:
- virtual views::Widget* CreateWidget() OVERRIDE {
- // This is necessary to register apps.
- // TODO(oshima): This will become unnecessary once the
- // shell_app_window is removed.
- GetContentsView();
- return web_view_->GetWidget();
- }
-
- // AppActivity:
- virtual views::WebView* GetWebView() OVERRIDE { return web_view_; }
-
- // Not owned.
- extensions::AppWindow* app_window_;
- views::WebView* web_view_;
-
- DISALLOW_COPY_AND_ASSIGN(ChromeAppActivity);
-};
-
-} // namespace
-
-Activity* ContentActivityFactory::CreateAppActivity(
- extensions::AppWindow* app_window,
- views::WebView* web_view) {
- return new ChromeAppActivity(app_window, web_view);
-}
-
-} // namespace athena
« no previous file with comments | « athena/content/chrome/DEPS ('k') | athena/content/content_activity_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698