Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: athena/content/content_activity_factory.cc

Issue 587953002: [Athena: Cleanup] consolidate ChromeAppActivity and ShellAppActivity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « athena/content/chrome/content_activity_factory.cc ('k') | athena/content/shell/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/content/content_activity_factory.h" 5 #include "athena/content/content_activity_factory.h"
6 6
7 #include "athena/content/app_activity.h"
7 #include "athena/content/web_activity.h" 8 #include "athena/content/web_activity.h"
8 #include "base/logging.h" 9 #include "base/logging.h"
9 10
10 namespace athena { 11 namespace athena {
11 12
12 ContentActivityFactory::ContentActivityFactory() { 13 ContentActivityFactory::ContentActivityFactory() {
13 } 14 }
14 15
15 ContentActivityFactory::~ContentActivityFactory() {} 16 ContentActivityFactory::~ContentActivityFactory() {}
16 17
17 Activity* ContentActivityFactory::CreateWebActivity( 18 Activity* ContentActivityFactory::CreateWebActivity(
18 content::BrowserContext* browser_context, 19 content::BrowserContext* browser_context,
19 const base::string16& title, 20 const base::string16& title,
20 const GURL& url) { 21 const GURL& url) {
21 return new WebActivity(browser_context, title, url); 22 return new WebActivity(browser_context, title, url);
22 } 23 }
23 24
25 Activity* ContentActivityFactory::CreateAppActivity(
26 extensions::AppWindow* app_window,
27 views::WebView* web_view) {
28 return new AppActivity(app_window, web_view);
29 }
30
24 ActivityFactory* CreateContentActivityFactory() { 31 ActivityFactory* CreateContentActivityFactory() {
25 return new ContentActivityFactory(); 32 return new ContentActivityFactory();
26 } 33 }
27 34
28 } // namespace athena 35 } // namespace athena
OLDNEW
« no previous file with comments | « athena/content/chrome/content_activity_factory.cc ('k') | athena/content/shell/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698