Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: extensions/shell/browser/shell_app_window_client.cc

Issue 587913002: app_shell: Remove some NOTIMPLEMENTED from ShellNativeAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/browser/shell_app_delegate.cc ('k') | extensions/shell/browser/shell_native_app_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/shell_app_window_client.cc
diff --git a/extensions/shell/browser/shell_app_window_client.cc b/extensions/shell/browser/shell_app_window_client.cc
index 90287a601fbfd2751ebdd389a92263bba42d672b..734df75e9546a351041fafd96ae292588f77181d 100644
--- a/extensions/shell/browser/shell_app_window_client.cc
+++ b/extensions/shell/browser/shell_app_window_client.cc
@@ -4,6 +4,8 @@
#include "extensions/shell/browser/shell_app_window_client.h"
+#include <vector>
+
#include "extensions/browser/app_window/app_window.h"
#include "extensions/shell/browser/desktop_controller.h"
#include "extensions/shell/browser/shell_native_app_window.h"
@@ -39,11 +41,12 @@ NativeAppWindow* ShellAppWindowClient::CreateNativeAppWindow(
}
void ShellAppWindowClient::IncrementKeepAliveCount() {
- NOTIMPLEMENTED();
+ // app_shell runs until the system powers off, so it doesn't need to track
+ // open apps or windows to keep itself alive.
}
void ShellAppWindowClient::DecrementKeepAliveCount() {
- NOTIMPLEMENTED();
+ // See IncrementKeepAliveCount().
}
void ShellAppWindowClient::OpenDevToolsWindow(
« no previous file with comments | « extensions/shell/browser/shell_app_delegate.cc ('k') | extensions/shell/browser/shell_native_app_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698