Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 587893002: [Checkstyle] Enable boolean simplification and fix up some issues. (Closed)

Created:
6 years, 3 months ago by aurimas (slooooooooow)
Modified:
6 years, 3 months ago
Reviewers:
Ted C, nyquist, boliu
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, haitaol+watch_chromium.org, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Checkstyle] Enable boolean simplification and empty expression checks. Fix up some issues along the way. BUG=318404 TBR=nyquist@chromium.org,boliu@chromium.org Committed: https://crrev.com/5f746599b9025d5b15b7bb81c62ce36d05e57d93 Cr-Commit-Position: refs/heads/master@{#295884}

Patch Set 1 #

Patch Set 2 : Add no empty statements check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/ObserverList.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/accessibility/FontSizePrefs.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/TranslateUtil.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
aurimas (slooooooooow)
tedchoc: PTAL.
6 years, 3 months ago (2014-09-19 22:39:54 UTC) #2
Ted C
lgtm
6 years, 3 months ago (2014-09-20 00:03:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587893002/20001
6 years, 3 months ago (2014-09-20 17:41:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2bb31adaa4cb9220dacb985ffdf29f9d26bea2c4
6 years, 3 months ago (2014-09-20 18:43:14 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5f746599b9025d5b15b7bb81c62ce36d05e57d93 Cr-Commit-Position: refs/heads/master@{#295884}
6 years, 3 months ago (2014-09-20 18:43:53 UTC) #8
nyquist
lgtm
6 years, 3 months ago (2014-09-20 22:19:07 UTC) #9
boliu
6 years, 3 months ago (2014-09-22 17:35:55 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698