Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 587893002: [Checkstyle] Enable boolean simplification and fix up some issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add no empty statements check Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd"> 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd">
3 3
4 <!-- 4 <!--
5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle
6 --> 6 -->
7 <module name="Checker"> 7 <module name="Checker">
8 <property name="severity" value="warning"/> 8 <property name="severity" value="warning"/>
9 <property name="charset" value="UTF-8"/> 9 <property name="charset" value="UTF-8"/>
10 <module name="TreeWalker"> 10 <module name="TreeWalker">
(...skipping 23 matching lines...) Expand all
34 <property name="scope" value="public"/> 34 <property name="scope" value="public"/>
35 <property name="allowMissingParamTags" value="true"/> 35 <property name="allowMissingParamTags" value="true"/>
36 <property name="allowMissingPropertyJavadoc" value="true"/> 36 <property name="allowMissingPropertyJavadoc" value="true"/>
37 <property name="allowMissingReturnTag" value="true"/> 37 <property name="allowMissingReturnTag" value="true"/>
38 <property name="allowMissingThrowsTags" value="true"/> 38 <property name="allowMissingThrowsTags" value="true"/>
39 </module> 39 </module>
40 <module name="PackageName"> 40 <module name="PackageName">
41 <property name="severity" value="error"/> 41 <property name="severity" value="error"/>
42 <property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]{1,})*$"/> 42 <property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]{1,})*$"/>
43 </module> 43 </module>
44 <module name="SimplifyBooleanExpression">
45 <property name="severity" value="error"/>
46 </module>
47 <module name="SimplifyBooleanReturn">
48 <property name="severity" value="error"/>
49 </module>
44 <module name="TypeName"> 50 <module name="TypeName">
45 <property name="severity" value="error"/> 51 <property name="severity" value="error"/>
46 </module> 52 </module>
47 <module name="ConstantName"> 53 <module name="ConstantName">
48 <property name="severity" value="error"/> 54 <property name="severity" value="error"/>
49 <property name="format" value="^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*)|(s[A-Z][a-zA -Z0-9]*)$"/> 55 <property name="format" value="^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*)|(s[A-Z][a-zA -Z0-9]*)$"/>
50 <message key="name.invalidPattern" value="Static final field names must ei ther be all caps (e.g. int HEIGHT_PX) for 'true' constants, or start with s (e.g . AtomicInteger sNextId or Runnable sSuspendTask) for fields with mutable state or that don't 'feel' like constants."/> 56 <message key="name.invalidPattern" value="Static final field names must ei ther be all caps (e.g. int HEIGHT_PX) for 'true' constants, or start with s (e.g . AtomicInteger sNextId or Runnable sSuspendTask) for fields with mutable state or that don't 'feel' like constants."/>
51 </module> 57 </module>
52 <!-- Non-public, non-static field names start with m. --> 58 <!-- Non-public, non-static field names start with m. -->
53 <module name="MemberName"> 59 <module name="MemberName">
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 </module> 128 </module>
123 <module name="NoWhitespaceAfter"> 129 <module name="NoWhitespaceAfter">
124 <property name="severity" value="error"/> 130 <property name="severity" value="error"/>
125 <property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNA RY_PLUS"/> 131 <property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNA RY_PLUS"/>
126 </module> 132 </module>
127 <module name="NoWhitespaceBefore"> 133 <module name="NoWhitespaceBefore">
128 <property name="severity" value="error"/> 134 <property name="severity" value="error"/>
129 <property name="allowLineBreaks" value="true"/> 135 <property name="allowLineBreaks" value="true"/>
130 <property name="tokens" value="SEMI, DOT, POST_DEC, POST_INC"/> 136 <property name="tokens" value="SEMI, DOT, POST_DEC, POST_INC"/>
131 </module> 137 </module>
138 <module name="EmptyStatement">
139 <property name="severity" value="error"/>
140 </module>
132 <module name="NoFinalizer"> 141 <module name="NoFinalizer">
133 <property name="severity" value="warning"/> 142 <property name="severity" value="warning"/>
134 </module> 143 </module>
135 <module name="ParenPad"> 144 <module name="ParenPad">
136 <property name="severity" value="warning"/> 145 <property name="severity" value="warning"/>
137 </module> 146 </module>
138 <module name="ImportOrder"> 147 <module name="ImportOrder">
139 <property name="severity" value="error"/> 148 <property name="severity" value="error"/>
140 <message key="import.ordering" value="Wrong order for {0} import. Use :Jav aImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/> 149 <message key="import.ordering" value="Wrong order for {0} import. Use :Jav aImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/>
141 <property name="groups" value="android, com, dalvik, gov, junit, libcore, net, org, java, javax"/> 150 <property name="groups" value="android, com, dalvik, gov, junit, libcore, net, org, java, javax"/>
(...skipping 20 matching lines...) Expand all
162 <module name="RegexpSingleline"> 171 <module name="RegexpSingleline">
163 <property name="severity" value="error"/> 172 <property name="severity" value="error"/>
164 <property name="format" value="[ \t]+$"/> 173 <property name="format" value="[ \t]+$"/>
165 <property name="message" value="Trailing whitespace"/> 174 <property name="message" value="Trailing whitespace"/>
166 </module> 175 </module>
167 <module name="RegexpHeader"> 176 <module name="RegexpHeader">
168 <property name="severity" value="error"/> 177 <property name="severity" value="error"/>
169 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/> 178 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/>
170 </module> 179 </module>
171 </module> 180 </module>
OLDNEW
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698