content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java - Issue 587893002: [Checkstyle] Enable boolean simplification and fix up some issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java

Issue 587893002: [Checkstyle] Enable boolean simplification and fix up some issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add no empty statements check Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/android/javatests/src/org/chromium/chrome/test/util/TranslateUtil.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java b/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java

index 76951c1ee57ece905e8b78189ed1ccd5d84c1095..ded0664c6296157b5f02f2260aacb8c15a4f64f0 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java

@@ -122,9 +122,9 @@ public abstract class ContentReadbackHandler {

private native long nativeInit();

private native void nativeDestroy(long nativeContentReadbackHandler);

- private native void nativeGetContentBitmap(long nativeContentReadbackHandler, int readback_id,

+ private native void nativeGetContentBitmap(long nativeContentReadbackHandler, int readbackId,

float scale, Bitmap.Config config, float x, float y, float width, float height,

Object contentViewCore);

private native void nativeGetCompositorBitmap(long nativeContentReadbackHandler,

- int readback_id, long nativeWindowAndroid);

+ int readbackId, long nativeWindowAndroid);

}