Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 587853003: Revert of Removing browser.Start() and instead starts the browser at the point of creation. (Closed)

Created:
6 years, 3 months ago by wuhu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Removing browser.Start() and instead starts the browser at the point of creation. (patchset #5 id:80001 of https://codereview.chromium.org/565803002/) Reason for revert: missed changing constructor for CrOS browser Original issue's description: > Removing browser.Start() and instead starts the browser at the point of creation. > > BUG=412126 > > Committed: https://crrev.com/01c68e8765254d9971296b291ff718b4f6af3004 > Cr-Commit-Position: refs/heads/master@{#295591} TBR=nednguyen@google.com,slamm@chromium.org,slamm@google.com NOTREECHECKS=true NOTRY=true BUG=412126 Committed: https://crrev.com/5080b5ed9029aa2e79096ec2041349364f9b95c0 Cr-Commit-Position: refs/heads/master@{#295791}

Patch Set 1 #

Messages

Total messages: 9 (2 generated)
wuhu
Created Revert of Removing browser.Start() and instead starts the browser at the point of creation.
6 years, 3 months ago (2014-09-19 22:11:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587853003/1
6 years, 3 months ago (2014-09-19 22:12:47 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-19 22:12:50 UTC) #4
nednguyen
lgtm
6 years, 3 months ago (2014-09-19 22:13:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587853003/1
6 years, 3 months ago (2014-09-19 22:15:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 01f3f9dfedec366dd21abf3a22ec9226e28aa8c7
6 years, 3 months ago (2014-09-19 22:17:08 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 22:17:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5080b5ed9029aa2e79096ec2041349364f9b95c0
Cr-Commit-Position: refs/heads/master@{#295791}

Powered by Google App Engine
This is Rietveld 408576698