tools/telemetry/telemetry/page/page_runner.py - Issue 587853003: Revert of Removing browser.Start() and instead starts the browser at the point of creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 587853003: Revert of Removing browser.Start() and instead starts the browser at the point of creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index 34adb8e524a50619708d0d59559bfc3a60d8df10..6b112e83979e30f37537ec003e67e1fc0d9ed158 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -45,14 +45,17 @@

# Create a browser.

if not self.browser:

test.CustomizeBrowserOptionsForSinglePage(page, finder_options)

- possible_browser.SetReplayArchivePath(archive_path,

+ self.browser = possible_browser.Create()

+ self.browser.credentials.credentials_path = credentials_path

+ # Set up WPR path on the new browser.

+ self.browser.SetReplayArchivePath(archive_path,

self._append_to_existing_wpr,

page_set.make_javascript_deterministic)

- possible_browser.SetCredentialsPath(credentials_path)

self._last_archive_path = page.archive_path

test.WillStartBrowser(possible_browser.platform)

- self.browser = possible_browser.Create()

+ self.browser.Start()

test.DidStartBrowser(self.browser)

if self._first_browser:

« no previous file with comments | « tools/telemetry/telemetry/core/possible_browser.py ('k') | tools/telemetry/telemetry/unittest/browser_test_case.py » ('j') | no next file with comments »