tools/telemetry/telemetry/core/browser_credentials.py - Issue 587853003: Revert of Removing browser.Start() and instead starts the browser at the point of creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser_credentials.py

Issue 587853003: Revert of Removing browser.Start() and instead starts the browser at the point of creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/browser_credentials.py

diff --git a/tools/telemetry/telemetry/core/browser_credentials.py b/tools/telemetry/telemetry/core/browser_credentials.py

index faeadeb49c0faba7a7011bb18bec61f5afacae1f..8527ecd68baf5c5eaf2f3c2747ba2999e2835d7f 100644

--- a/tools/telemetry/telemetry/core/browser_credentials.py

+++ b/tools/telemetry/telemetry/core/browser_credentials.py

@@ -67,11 +67,11 @@

self._backends[credentials_type].LoginNoLongerNeeded(tab)

@property

- def credentials_path(self): # pylint: disable=E0202

+ def credentials_path(self):

return self._credentials_path

@credentials_path.setter

- def credentials_path(self, credentials_path): # pylint: disable=E0202

+ def credentials_path(self, credentials_path):

self._credentials_path = credentials_path

self._RebuildCredentials()

« no previous file with comments | « tools/telemetry/telemetry/core/browser.py ('k') | tools/telemetry/telemetry/core/extension_unittest.py » ('j') | no next file with comments »