Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: src/IceCfg.cpp

Issue 586943003: Subzero: Change the way bitcast stack slot lowering is handled. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Add clarifying comment to asType() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceCfg.h ('k') | src/IceCfgNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCfg.cpp
diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp
index 44393230daf345055f2853f0c465ef58ebb9be81..a08bebb31dbc86e66eea5777860e57b99e584791 100644
--- a/src/IceCfg.cpp
+++ b/src/IceCfg.cpp
@@ -45,13 +45,9 @@ CfgNode *Cfg::makeNode(const IceString &Name) {
return Node;
}
-// Create a new Variable with a particular type and an optional
-// name. The Node argument is the node where the variable is defined.
Variable *Cfg::makeVariable(Type Ty, const CfgNode *Node,
const IceString &Name) {
- SizeT Index = Variables.size();
- Variables.push_back(Variable::create(this, Ty, Node, Index, Name));
- return Variables[Index];
+ return makeVariable<Variable>(Ty, Node, Name);
}
void Cfg::addArg(Variable *Arg) {
@@ -359,7 +355,7 @@ void Cfg::dump(const IceString &Message) {
}
Str << ") {\n";
}
- setCurrentNode(NULL);
+ resetCurrentNode();
if (getContext()->isVerbose(IceV_Liveness)) {
// Print summary info about variables
for (VarList::const_iterator I = Variables.begin(), E = Variables.end();
« no previous file with comments | « src/IceCfg.h ('k') | src/IceCfgNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698