Subzero: Change the way bitcast stack slot lowering is handled.

src/IceCfg.cpp

 //===- subzero/src/IceCfg.cpp - Control flow graph implementation ---------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the Cfg class, including constant pool
@@ skipping 27 matching lines @@
   Ctx->getStrDump() << "ICE translation error: " << ErrorMessage << "\n";
 }
 
 CfgNode *Cfg::makeNode(const IceString &Name) {
   SizeT LabelIndex = Nodes.size();
   CfgNode *Node = CfgNode::create(this, LabelIndex, Name);
   Nodes.push_back(Node);
   return Node;
 }
 
-// Create a new Variable with a particular type and an optional
-// name.  The Node argument is the node where the variable is defined.
 Variable *Cfg::makeVariable(Type Ty, const CfgNode *Node,
                             const IceString &Name) {
-  SizeT Index = Variables.size();
-  Variables.push_back(Variable::create(this, Ty, Node, Index, Name));
-  return Variables[Index];
+  return makeVariable<Variable>(Ty, Node, Name);
 }
 
 void Cfg::addArg(Variable *Arg) {
   Arg->setIsArg(this);
   Args.push_back(Arg);
 }
 
 // Returns whether the stack frame layout has been computed yet.  This
 // is used for dumping the stack frame location of Variables.
 bool Cfg::hasComputedFrame() const { return getTarget()->hasComputedFrame(); }
@@ skipping 287 matching lines @@
       Str << "internal ";
     Str << ReturnType << " @" << getFunctionName() << "(";
     for (SizeT i = 0; i < Args.size(); ++i) {
       if (i > 0)
         Str << ", ";
       Str << Args[i]->getType() << " ";
       Args[i]->dump(this);
     }
     Str << ") {\n";
   }
-  setCurrentNode(NULL);
+  resetCurrentNode();
   if (getContext()->isVerbose(IceV_Liveness)) {
     // Print summary info about variables
     for (VarList::const_iterator I = Variables.begin(), E = Variables.end();
          I != E; ++I) {
       Variable *Var = *I;
       Str << "//"
           << " multiblock=" << Var->isMultiblockLife() << " "
           << " weight=" << Var->getWeight() << " ";
       Var->dump(this);
       if (Variable *Pref = Var->getPreferredRegister()) {
@@ skipping 10 matching lines @@
   for (NodeList::const_iterator I = Nodes.begin(), E = Nodes.end(); I != E;
        ++I) {
     (*I)->dump(this);
   }
   if (getContext()->isVerbose(IceV_Instructions)) {
     Str << "}\n";
   }
 }
 
 } // end of namespace Ice