Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/IceCfg.h

Issue 586943003: Subzero: Change the way bitcast stack slot lowering is handled. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Add clarifying comment to asType() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceCfg.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCfg.h
diff --git a/src/IceCfg.h b/src/IceCfg.h
index a2582eb4f2e1038b0df746e6535ff023a13e215f..7a265ad442602edaa7dffed15391d9ffe5fff50a 100644
--- a/src/IceCfg.h
+++ b/src/IceCfg.h
@@ -61,6 +61,17 @@ public:
InstNumberT newInstNumber() { return NextInstNumber++; }
// Manage Variables.
+ // Create a new Variable with a particular type and an optional
+ // name. The Node argument is the node where the variable is defined.
+ template <typename T>
+ T *makeVariable(Type Ty, const CfgNode *Node, const IceString &Name = "") {
+ SizeT Index = Variables.size();
+ T *Var = T::create(this, Ty, Node, Index, Name);
+ Variables.push_back(Var);
+ return Var;
+ }
+ // TODO(stichnot): Remove this function with C++11, and use default
+ // argument <typename T=Variable> above.
Variable *makeVariable(Type Ty, const CfgNode *Node,
const IceString &Name = "");
SizeT getNumVariables() const { return Variables.size(); }
@@ -99,6 +110,7 @@ public:
// Manage the CurrentNode field, which is used for validating the
// Variable::DefNode field during dumping/emitting.
void setCurrentNode(const CfgNode *Node) { CurrentNode = Node; }
+ void resetCurrentNode() { setCurrentNode(NULL); }
const CfgNode *getCurrentNode() const { return CurrentNode; }
void emit();
@@ -155,8 +167,8 @@ private:
// CurrentNode is maintained during dumping/emitting just for
// validating Variable::DefNode. Normally, a traversal over
// CfgNodes maintains this, but before global operations like
- // register allocation, setCurrentNode(NULL) should be called to
- // avoid spurious validation failures.
+ // register allocation, resetCurrentNode() should be called to avoid
+ // spurious validation failures.
const CfgNode *CurrentNode;
Cfg(const Cfg &) LLVM_DELETED_FUNCTION;
« no previous file with comments | « no previous file | src/IceCfg.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698