Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 586543002: Make the "bookmark all tabs" sheet outline view scroll horizontally. (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the "bookmark all tabs" sheet outline view scroll horizontally. This is already how the bookmark editor sheet behaves. The xib changes: - Turn off "headers". - Set the column autoresizing style to "last column only". BUG=414266 TEST=as in bug Committed: https://crrev.com/1829b969ab012dda7bb061f1be8b50358ee81fba Cr-Commit-Position: refs/heads/master@{#295994}

Patch Set 1 #

Patch Set 2 : rebase? #

Patch Set 3 : back to normal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -40 lines) Patch
M chrome/app/nibs/BookmarkAllTabs.xib View 2 12 chunks +6 lines, -40 lines 0 comments Download

Messages

Total messages: 32 (15 generated)
Avi (use Gerrit)
6 years, 3 months ago (2014-09-18 22:28:07 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-19 14:01:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586543002/1
6 years, 3 months ago (2014-09-20 01:09:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/17379) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/5863) android_chromium_gn_compile_dbg ...
6 years, 3 months ago (2014-09-20 01:14:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/17379) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/5863) android_chromium_gn_compile_dbg ...
6 years, 3 months ago (2014-09-20 01:15:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586543002/1
6 years, 3 months ago (2014-09-22 14:51:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/17620)
6 years, 3 months ago (2014-09-22 14:58:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586543002/1
6 years, 3 months ago (2014-09-22 15:09:46 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17143) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11928)
6 years, 3 months ago (2014-09-22 15:17:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586543002/1
6 years, 3 months ago (2014-09-22 15:24:57 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/11116) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17148) ios_rel_device_ninja ...
6 years, 3 months ago (2014-09-22 15:28:31 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586543002/1
6 years, 3 months ago (2014-09-22 15:28:55 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17152) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11936)
6 years, 3 months ago (2014-09-22 15:32:34 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586543002/20001
6 years, 3 months ago (2014-09-22 15:44:05 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586543002/40001
6 years, 3 months ago (2014-09-22 16:04:53 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 2aad32d5ddb318af45b47903f213035883f83789
6 years, 3 months ago (2014-09-22 16:50:14 UTC) #31
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 16:50:48 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1829b969ab012dda7bb061f1be8b50358ee81fba
Cr-Commit-Position: refs/heads/master@{#295994}

Powered by Google App Engine
This is Rietveld 408576698