Yosemite: Don't show the default placeholder of NSSearchFieldCell.

Yosemite: Don't show the default placeholder of NSSearchFieldCell.

We need to call setCenteredLook:NO on Yosemite.
This CL was inspired by WebKit r168870 by dino@apple [1].

[1] http://trac.webkit.org/changeset/168870

BUG=394714
TEST=None for now; This change will be covered with existing tests
    when we add Yosemite buildbot.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182445

[tkent, 2014-09-22 04:57:14]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org, rsesek@chromium.org

[tkent, 2014-09-22 04:57:14]

Please review this.

[keishi, 2014-09-22 06:13:06]

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderThemeChromiumMac.mm:1674: NSInvocation* invocation =
[NSInvocation invocationWithMethodSignature: signature];
I think you should be able to do

NSNumber *boolValue = [NSNumber numberWithBool:NO];
[m_search.get() performSelector:SEL withObject:boolValue];

[tkent, 2014-09-22 08:00:34]

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderThemeChromiumMac.mm:1674: NSInvocation* invocation =
[NSInvocation invocationWithMethodSignature: signature];
On 2014/09/22 06:13:05, keishi wrote:
> I think you should be able to do
> 
> NSNumber *boolValue = [NSNumber numberWithBool:NO];
> [m_search.get() performSelector:SEL withObject:boolValue];

I confirmed it didn't work.  It threw no exception, but looked no effect.

[keishi, 2014-09-22 08:56:58]

lgtm

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderThemeChromiumMac.mm:1674: NSInvocation* invocation =
[NSInvocation invocationWithMethodSignature: signature];
Strange.

[Robert Sesek, 2014-09-22 14:42:49]

LGTM

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderThemeChromiumMac.mm:1674: NSInvocation* invocation =
[NSInvocation invocationWithMethodSignature: signature];
nit: no space after :

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderThemeChromiumMac.mm:1674: NSInvocation* invocation =
[NSInvocation invocationWithMethodSignature: signature];
On 2014/09/22 08:00:34, tkent (high review load) wrote:
> On 2014/09/22 06:13:05, keishi wrote:
> > I think you should be able to do
> > 
> > NSNumber *boolValue = [NSNumber numberWithBool:NO];
> > [m_search.get() performSelector:SEL withObject:boolValue];
> 
> I confirmed it didn't work.  It threw no exception, but looked no effect.

Right, this shouldn't work because one NSNumber is an object and this method is
accepting a BOOL literal -- they are not the same thing.

[tkent, 2014-09-22 19:57:41]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-09-22 19:58:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586413002/1

[commit-bot: I haz the power, 2014-09-22 20:02:48]

Committed patchset #1 (id:1) as 182445

[Robert Sesek, 2014-09-22 20:58:31]

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderThemeChromiumMac.mm:1674: NSInvocation* invocation =
[NSInvocation invocationWithMethodSignature: signature];
On 2014/09/22 14:42:49, rsesek wrote:
> nit: no space after :

You didn't address this comment.

[tkent, 2014-09-23 22:39:10]

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/586413002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderThemeChromiumMac.mm:1674: NSInvocation* invocation =
[NSInvocation invocationWithMethodSignature: signature];
On 2014/09/22 20:58:31, rsesek wrote:
> On 2014/09/22 14:42:49, rsesek wrote:
> > nit: no space after :
> 
> You didn't address this comment.

Oops, I overlooked the comment.  Will address it in another CL.